From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5494713E043 for ; Fri, 26 Apr 2024 09:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714123415; cv=none; b=N1+u0n/Ojiw3p86XX83Dq3LqRPMIRKPcIXvsORR+ARl6/sFRLqSRH+LZERRCIxO4JAmqEWTcS2fiu3wZCMCT2h1TqM3UgrnRzbFmvRiLSvdSItPXVkP04DmXBb8w2ocyzeEPp6GNu+DFtoFO1ifoELJgspWh1lMFY1VfFvGl69A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714123415; c=relaxed/simple; bh=Udl46LR7XVoXfrBKhl6mIDBjIxqJOh882IzI0S4UAM4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tbbFaNBtS9zCOsXM9ybhZsyfuwQ2gdJIGmlSpQWH6kD5m3xlkqOoxWj/e/zE3ePmk8MVF0O8sadBYbLYJq/Us0PPrgDIye+OWsN65wwr+TMYTIgkkArq0C/I8K2vkAq9ehiae3Ao5LRXaaYiLpC8oLWqJP+mQTbtIYdo0MfNslw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZSfzzAQA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZSfzzAQA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714123413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRAd8wfnSBnkmuLuRNYN/BGd3qvtIlEXRV1WTPss9aM=; b=ZSfzzAQAhgZxujKRSys68q292URUOoGyft6rzm0FWsj8AjanGJnImCJ9fquqF+QBB2kn3a auIT8Hq1RGeG89pk6jOIIhv52DotF6kMMPYP8xFgYeY08t6I2z/tenrEkdit4plEL/XVyd VWMzS7QQwmBQ8tmCuaulartEzrCzLhE= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-4UPaec9YNQu5WJjC7UGJ4Q-1; Fri, 26 Apr 2024 05:23:31 -0400 X-MC-Unique: 4UPaec9YNQu5WJjC7UGJ4Q-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2a4f59746f7so2141894a91.1 for ; Fri, 26 Apr 2024 02:23:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714123410; x=1714728210; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iRAd8wfnSBnkmuLuRNYN/BGd3qvtIlEXRV1WTPss9aM=; b=IJ3CH9tNcZVwTLqNEdstGbQ8+D20p5Ma2NCRPPLCJtInG5IzAyv9vsF1TxqOLVp+wZ saPCopqEJgKWehJ/TF2a53vOVBEB+zEMGAm3b5+9XwWONMcxp6MG1A6PPlfa9qxI0Yut 1MrkNYRVBLw/l75wYK8IX7bzw+LCE6/HBjrjRHaJvqxjbm5pKU+UJ0g68Uvslvjsz1Ns lWZ5VQl5hWvndvpYTVxAG2/Z4Jd0vrJJj9f8dTQWgVUqdlZerzRpSKUPiRltGIG8ZLAO fZX2XHII6vJSoH9F5Ia1GvzaN7rSUk0psb7Mk8BBsIiXnI2bM6r394+URIRooUQQ2J5O xCcQ== X-Forwarded-Encrypted: i=1; AJvYcCVCjCSRPsVxnQMgei7KDU7JMgVBNDYYDb3KN5H7F7EaMxAoPJJ5A60ZUEabuC1rwkpCOJgROhNV5kltn37nlRE2a4yUglJ/ X-Gm-Message-State: AOJu0Yxl+honmdflqOlLaWQIW/do5FgRY90ySkNRcvqtTlYaTbtbhNRd +BQmUKkTunlgwxaqIhCbUM69tAfrobDtX8bx9+tAXGCAd0lBM/FK022RYd+QMgSnw4M/sTqz0yq BIwpt6HJP2LyV6QCabCbD7JAEDAgFtSVwgZdxqptvPSBYmhLnkdct+Q== X-Received: by 2002:a17:903:11c3:b0:1e5:5bd7:87a4 with SMTP id q3-20020a17090311c300b001e55bd787a4mr2283752plh.16.1714123410671; Fri, 26 Apr 2024 02:23:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTmWdacAorvyOh8QQAQnPNEyl/iXm9VdRYljIzI/YjTWhI47bK72rLeP2m/Hny5DHEF82p7g== X-Received: by 2002:a17:903:11c3:b0:1e5:5bd7:87a4 with SMTP id q3-20020a17090311c300b001e55bd787a4mr2283739plh.16.1714123410303; Fri, 26 Apr 2024 02:23:30 -0700 (PDT) Received: from [192.168.68.50] ([43.252.112.88]) by smtp.gmail.com with ESMTPSA id r3-20020a170902be0300b001e27462b988sm15054500pls.61.2024.04.26.02.23.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 02:23:29 -0700 (PDT) Message-ID: <566817ae-90f0-4ec9-b54e-b9fdb635119e@redhat.com> Date: Fri, 26 Apr 2024 19:23:19 +1000 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 01/16] ACPI: processor: Simplify initial onlining to use same path for cold and hotplug To: Jonathan Cameron , Thomas Gleixner , Peter Zijlstra , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, Russell King , "Rafael J . Wysocki" , Miguel Luis , James Morse , Salil Mehta , Jean-Philippe Brucker , Catalin Marinas , Will Deacon Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , linuxarm@huawei.com, justin.he@arm.com, jianyong.wu@arm.com References: <20240418135412.14730-1-Jonathan.Cameron@huawei.com> <20240418135412.14730-2-Jonathan.Cameron@huawei.com> From: Gavin Shan In-Reply-To: <20240418135412.14730-2-Jonathan.Cameron@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/18/24 23:53, Jonathan Cameron wrote: > Separate code paths, combined with a flag set in acpi_processor.c to > indicate a struct acpi_processor was for a hotplugged CPU ensured that > per CPU data was only set up the first time that a CPU was initialized. > This appears to be unnecessary as the paths can be combined by letting > the online logic also handle any CPUs online at the time of driver load. > > Motivation for this change, beyond simplification, is that ARM64 > virtual CPU HP uses the same code paths for hotplug and cold path in > acpi_processor.c so had no easy way to set the flag for hotplug only. > Removing this necessity will enable ARM64 vCPU HP to reuse the existing > code paths. > > Leave noisy pr_info() in place but update it to not state the CPU > was hotplugged. > > Signed-off-by: Jonathan Cameron > > --- > v7: No change. > v6: New patch. > RFT: I have very limited test resources for x86 and other > architectures that may be affected by this change. > --- > drivers/acpi/acpi_processor.c | 1 - > drivers/acpi/processor_driver.c | 44 ++++++++++----------------------- > include/acpi/processor.h | 2 +- > 3 files changed, 14 insertions(+), 33 deletions(-) > Reviewed-by: Gavin Shan