From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7FEDC433FE for ; Wed, 19 Oct 2022 00:26:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 383AB4B8B0; Tue, 18 Oct 2022 20:26:34 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3sMYEANhMddH; Tue, 18 Oct 2022 20:26:32 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C90E54B8DC; Tue, 18 Oct 2022 20:26:32 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 80DD74B8B0 for ; Tue, 18 Oct 2022 20:26:31 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DqS4DncfyyRx for ; Tue, 18 Oct 2022 20:26:30 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2C9994B89B for ; Tue, 18 Oct 2022 20:26:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666139189; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2iRn13iSXiKN1tasBVGZtH8JeAlfEonkeX/dLbbng1k=; b=ONUR/ymhmcHnzWABfDpoLnj6HFYg0eMgHaUmfIdGHkU8rdIrfosDmgscdfNnmTdVyHkNxE QIMjTsLC0W8IPetr4+dyODJrqE+YFut3GFDfF6K4JjBPO/ub4161WzCLOmGlyttSOy6LHT R02UpflrszUxxHemeyUPRkt9IJpydDY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-141-y8oaFLu7N5emg5q9o1-lYw-1; Tue, 18 Oct 2022 20:26:28 -0400 X-MC-Unique: y8oaFLu7N5emg5q9o1-lYw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C8A1F3C01E0A; Wed, 19 Oct 2022 00:26:27 +0000 (UTC) Received: from [10.64.54.70] (vpn2-54-70.bne.redhat.com [10.64.54.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 506502028DC1; Wed, 19 Oct 2022 00:26:22 +0000 (UTC) Subject: Re: [PATCH 4/6] KVM: selftests: memslot_perf_test: Support variable guest page size To: "Maciej S. Szmigiero" References: <20221014071914.227134-1-gshan@redhat.com> <20221014071914.227134-5-gshan@redhat.com> <3eecebca-a526-d10a-02d3-496ce919d577@maciej.szmigiero.name> From: Gavin Shan Message-ID: <5bfbe050-a654-8400-e1f1-dcfa4dba13e6@redhat.com> Date: Wed, 19 Oct 2022 08:26:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Cc: kvm@vger.kernel.org, maz@kernel.org, linux-kernel@vger.kernel.org, zhenyzha@redhat.com, shan.gavin@gmail.com, kvmarm@lists.linux.dev, pbonzini@redhat.com, shuah@kernel.org, kvmarm@lists.cs.columbia.edu, ajones@ventanamicro.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Gavin Shan List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMTAvMTgvMjIgMTE6NTYgUE0sIE1hY2llaiBTLiBTem1pZ2llcm8gd3JvdGU6Cj4gT24gMTgu MTAuMjAyMiAwMjo1MSwgR2F2aW4gU2hhbiB3cm90ZToKPj4gT24gMTAvMTgvMjIgODo0NiBBTSwg R2F2aW4gU2hhbiB3cm90ZToKPj4+IE9uIDEwLzE4LzIyIDU6MzEgQU0sIE1hY2llaiBTLiBTem1p Z2llcm8gd3JvdGU6Cj4+Pj4gT24gMTQuMTAuMjAyMiAwOToxOSwgR2F2aW4gU2hhbiB3cm90ZToK Pj4+Pj4gVGhlIHRlc3QgY2FzZSBpcyBvYnZpb3VzbHkgYnJva2VuIG9uIGFhcmNoNjQgYmVjYXVz ZSBub24tNEtCIGd1ZXN0Cj4+Pj4+IHBhZ2Ugc2l6ZSBpcyBzdXBwb3J0ZWQuIFRoZSBndWVzdCBw YWdlIHNpemUgb24gYWFyY2g2NCBjb3VsZCBiZSA0S0IsCj4+Pj4+IDE2S0Igb3IgNjRLQi4KPj4+ Pj4KPj4+Pj4gVGhpcyBzdXBwb3J0cyB2YXJpYWJsZSBndWVzdCBwYWdlIHNpemUsIG1vc3RseSBm b3IgYWFyY2g2NC4KPj4+Pj4KPj4+Pj4gwqDCoCAtIFRoZSBob3N0IGRldGVybWluZXMgdGhlIGd1 ZXN0IHBhZ2Ugc2l6ZSB3aGVuIHZpcnR1YWwgbWFjaGluZSBpcwo+Pj4+PiDCoMKgwqDCoCBjcmVh dGVkLiBUaGUgdmFsdWUgaXMgYWxzbyBwYXNzZWQgdG8gZ3Vlc3QgdGhyb3VnaCB0aGUgc3luY2hy b25pemF0aW9uCj4+Pj4+IMKgwqDCoMKgIGFyZWEuCj4+Pj4+Cj4+Pj4+IMKgwqAgLSBUaGUgbnVt YmVyIG9mIGd1ZXN0IHBhZ2VzIGFyZSB1bmtub3duIHVudGlsIHRoZSB2aXJ0dWFsIG1hY2hpbmUK Pj4+Pj4gwqDCoMKgwqAgaXMgdG8gYmUgY3JlYXRlZC4gU28gYWxsIHRoZSByZWxhdGVkIG1hY3Jv cyBhcmUgZHJvcHBlZC4gSW5zdGVhZCwKPj4+Pj4gwqDCoMKgwqAgdGhlaXIgdmFsdWVzIGFyZSBk eW5hbWljYWxseSBjYWxjdWxhdGVkIGJhc2VkIG9uIHRoZSBndWVzdCBwYWdlCj4+Pj4+IMKgwqDC oMKgIHNpemUuCj4+Pj4+Cj4+Pj4+IMKgwqAgLSBUaGUgc3RhdGljIGNoZWNrcyBvbiBtZW1vcnkg c2l6ZXMgYW5kIHBhZ2VzIGJlY29tZXMgZGVwZW5kZW50Cj4+Pj4+IMKgwqDCoMKgIG9uIGd1ZXN0 IHBhZ2Ugc2l6ZSwgd2hpY2ggaXMgdW5rbm93biB1bnRpbCB0aGUgdmlydHVhbCBtYWNoaW5lCj4+ Pj4+IMKgwqDCoMKgIGlzIGFib3V0IHRvIGJlIGNyZWF0ZWQuIFNvIGFsbCB0aGUgc3RhdGljIGNo ZWNrcyBhcmUgY29udmVydGVkCj4+Pj4+IMKgwqDCoMKgIHRvIGR5bmFtaWMgY2hlY2tzLCBkb25l IGluIGNoZWNrX21lbW9yeV9zaXplcygpLgo+Pj4+Pgo+Pj4+PiDCoMKgIC0gQXMgdGhlIGFkZHJl c3MgcGFzc2VkIHRvIG1hZHZpc2UoKSBzaG91bGQgYmUgYWxpZ25lZCB0byBob3N0IHBhZ2UsCj4+ Pj4+IMKgwqDCoMKgIHRoZSBzaXplIG9mIHBhZ2UgY2h1bmsgaXMgYXV0b21hdGljYWxseSBzZWxl Y3RlZCwgb3RoZXIgdGhhbiBvbmUKPj4+Pj4gwqDCoMKgwqAgcGFnZS4KPj4+Pj4KPj4+Pj4gwqDC oCAtIEFsbCBvdGhlciBjaGFuZ2VzIGluY2x1ZGVkIGluIHRoaXMgcGF0Y2ggYXJlIGFsbW9zdCBt ZWNoYW5pY2FsCj4+Pj4+IMKgwqDCoMKgIHJlcGxhY2luZyAnNDA5Nicgd2l0aCAnZ3Vlc3RfcGFn ZV9zaXplJy4KPj4+Pj4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogR2F2aW4gU2hhbiA8Z3NoYW5AcmVk aGF0LmNvbT4KPj4+Pj4gLS0tCj4+Pj4+IMKgIC4uLi90ZXN0aW5nL3NlbGZ0ZXN0cy9rdm0vbWVt c2xvdF9wZXJmX3Rlc3QuYyB8IDE5MSArKysrKysrKysrKy0tLS0tLS0KPj4+Pj4gwqAgMSBmaWxl IGNoYW5nZWQsIDExNSBpbnNlcnRpb25zKCspLCA3NiBkZWxldGlvbnMoLSkKPj4+Pj4KPj4+Pj4g ZGlmZiAtLWdpdCBhL3Rvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL2t2bS9tZW1zbG90X3BlcmZfdGVz dC5jIGIvdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMva3ZtL21lbXNsb3RfcGVyZl90ZXN0LmMKPj4+ Pj4gaW5kZXggZDVhYTkxNDhmOTZmLi5kNTg3YmQ5NTJmZjkgMTAwNjQ0Cj4+Pj4+IC0tLSBhL3Rv b2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL2t2bS9tZW1zbG90X3BlcmZfdGVzdC5jCj4+Pj4+ICsrKyBi L3Rvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL2t2bS9tZW1zbG90X3BlcmZfdGVzdC5jCj4gKC4uLikK Pj4+Pj4gQEAgLTc3LDggKzYxLDcgQEAgc3RhdGljX2Fzc2VydChNRU1fVEVTVF9VTk1BUF9TSVpF X1BBR0VTICUKPj4+Pj4gwqDCoCAqIGZvciB0aGUgdG90YWwgc2l6ZSBvZiAyNSBwYWdlcy4KPj4+ Pj4gwqDCoCAqIEhlbmNlLCB0aGUgbWF4aW11bSBzaXplIGhlcmUgaXMgNTAgcGFnZXMuCj4+Pj4+ IMKgwqAgKi8KPj4+Pj4gLSNkZWZpbmUgTUVNX1RFU1RfTU9WRV9TSVpFX1BBR0VTwqDCoMKgICg1 MCkKPj4+Pj4gLSNkZWZpbmUgTUVNX1RFU1RfTU9WRV9TSVpFwqDCoMKgwqDCoMKgwqAgKE1FTV9U RVNUX01PVkVfU0laRV9QQUdFUyAqIDQwOTYpCj4+Pj4+ICsjZGVmaW5lIE1FTV9URVNUX01PVkVf U0laRcKgwqDCoMKgwqDCoMKgIDB4MzIwMDAKPj4+Pgo+Pj4+IFRoZSBhYm92ZSBudW1iZXIgc2Vl bXMgbGVzcyByZWFkYWJsZSB0aGFuIGFuIGV4cGxpY2l0IHZhbHVlIG9mIDUwIHBhZ2VzLgo+Pj4+ Cj4+Pj4gSW4gYWRkaXRpb24gdG8gdGhhdCwgaXQncyA1MCBwYWdlcyBvbmx5IHdpdGggNGsgcGFn ZSBzaXplLCBzbyBhdCBsZWFzdAo+Pj4+IHRoZSBjb21tZW50IGFib3ZlIG5lZWRzIHRvIGJlIHVw ZGF0ZWQgdG8gcmVmbGVjdCB0aGlzIGZhY3QuCj4+Pj4KPj4+Cj4+PiBZZWFoLCBJIHdpbGwgY2hh bmdlIHRoZSBjb21tZW50cyBsaWtlIGJlbG93IGluIG5leHQgcmV2aXNpb24uCj4+Pgo+Pj4gwqDC oC8qCj4+PiDCoMKgICogV2hlbiBydW5uaW5nIHRoaXMgdGVzdCB3aXRoIDMyayBtZW1zbG90cywg YWN0dWFsbHkgMzI3NjMgZXhjbHVkaW5nCj4+PiDCoMKgICogdGhlIHJlc2VydmVkIG1lbW9yeSBz bG90IDAsIHRoZSBtZW1vcnkgZm9yIGVhY2ggc2xvdCBpcyAweDQwMDAgYnl0ZXMuCj4+PiDCoMKg ICogVGhlIGxhc3Qgc2xvdCBjb250YWlucyAweDE5MDAwIGJ5dGVzIG1lbW9yeS4gSGVuY2UsIHRo ZSBtYXhpbXVtIHNpemUKPj4+IMKgwqAgKiBoZXJlIGlzIDB4MzIwMDAgYnl0ZXMuCj4+PiDCoMKg ICovCj4+Pgo+Pgo+PiBJIHdpbGwgcmVwbGFjZSB0aG9zZSBudW1iZXJzIHdpdGggcmVhZGFibGUg b25lcyBsaWtlIGJlbG93IDopCj4+Cj4+IC8qCj4+IMKgwqAqIFdoZW4gcnVubmluZyB0aGlzIHRl c3Qgd2l0aCAzMmsgbWVtc2xvdHMsIGFjdHVhbGx5IDMyNzYzIGV4Y2x1ZGluZwo+PiDCoMKgKiB0 aGUgcmVzZXJ2ZWQgbWVtb3J5IHNsb3QgMCwgdGhlIG1lbW9yeSBmb3IgZWFjaCBzbG90IGlzIDE2 S0IuIFRoZQo+PiDCoMKgKiBsYXN0IHNsb3QgY29udGFpbnMgMTAwS0IgbWVtb3J5IHdpdGggdGhl IHJlbWFpbmluZyA4NEtCLiBIZW5jZSwKPj4gwqDCoCogdGhlIG1heGltdW0gc2l6ZSBpcyBkb3Vi bGUgb2YgdGhhdCAoMjAwS0IpCj4+IMKgwqAqLwo+IAo+IFN0aWxsLCB0aGVzZSBudW1iZXJzIGFy ZSBmb3IgeDg2LCB3aGljaCBoYXMgS1ZNX0lOVEVSTkFMX01FTV9TTE9UUwo+IGRlZmluZWQgYXMg My4KPiAKPiBBcyBmYXIgYXMgSSBjYW4gc2VlIGFhcmNoNjQgaGFzIEtWTV9JTlRFUk5BTF9NRU1f U0xPVFMgZXF1YWwgdG8gMCwgc28KPiB0aGlzIGFyY2ggaGFzIDMyNzY2IHNsb3QgYXZhaWxhYmxl IGZvciB0aGUgdGVzdCBtZW1vcnkuCj4gCj4gUXVpY2sgY2FsY3VsYXRpb25zIHNob3cgdGhhdCB0 aGlzIHdpbGwgcmVzdWx0IGluIDExMiBLaUIgb2YgbWVtb3J5IGluCj4gdGhlIGxhc3Qgc2xvdCBm b3IgNCBLaUIgcGFnZSBzaXplICh3aGlsZSBmb3IgNjQgS2lCIHBhZ2Ugc2l6ZSB0aGUKPiBtYXhp bXVtIHNsb3QgY291bnQgZm9yIHRoaXMgdGVzdCBpcyA4MTkyIGFueXdheSAtIG5vdCBjb3VudGlu ZyBzbG90IDApLgo+IAoKSXQgc2VlbXMgeW91ciBjYWxjdWxhdGlvbiBoYWQgKDUxMk1CKzY0S0Ip LCBpbnN0ZWFkIG9mICg1MTJNQis0S0IpLgpJbiB0aGlzIHBhcnRpY3VsYXIgcGF0Y2gsIHdlIHN0 aWxsIGhhdmUgKDUxMk1CKzRLQikuIEhvdyBhYm91dCB0byBjaGFuZ2UKbGlrZSBiZWxvdyBpbiB0 aGlzIHBhdGNoLiBJbiBuZXh0IHBhdGNoLCBpdCdzIGFkanVzdGVkIGFjY29yZGluZ2x5IGFmdGVy CndlIGhhdmUgKDUxMk1CKzY0S0IpLgoKKDEpIEluIHRoaXMgcGF0Y2gsIHRoZSBjb21tZW50IGlz IGNoYW5nZWQgdG8gYXMgYmVsb3cKCiAgICAgLyoKICAgICAgKiBXZSBoYXZlIGRpZmZlcmVudCBu dW1iZXIgb2YgbWVtb3J5IHNsb3RzLCBleGNsdWRpbmcgdGhlIHJlc2VydmVkCiAgICAgICogbWVt b3J5IHNsb3QgMCwgb24gdmFyaW91cyBhcmNoaXRlY3R1cmVzIGFuZCBjb25maWd1cmF0aW9ucy4g VGhlCiAgICAgICogbWVtb3J5IHNpemUgaW4gdGhpcyB0ZXN0IGlzIGNhbGN1bGF0ZWQgYnkgZG91 YmxpbmcgdGhlIG1heGltYWwKICAgICAgKiBtZW1vcnkgc2l6ZSBpbiBsYXN0IG1lbW9yeSBzbG90 LCB3aXRoIGFsaWdubWVudCB0byB0aGUgbGFyZ2VzdAogICAgICAqIHN1cHBvcnRlZCBwYWdlIHNp emUgKDY0S0IpLgogICAgICAqCiAgICAgICogYXJjaGl0ZWN0dXJlICAgc2xvdHMgICAgbWVtb3J5 LXBlci1zbG90ICAgIG1lbW9yeS1vbi1sYXN0LXNsb3QKICAgICAgKiAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogICAgICAqIHg4 Ni00S0IgICAgICAgIDMyNzYzICAgIDE2S0IgICAgICAgICAgICAgICAxMDBLQgogICAgICAqIGFy bTY0LTRLQiAgICAgIDMyNzY2ICAgIDE2S0IgICAgICAgICAgICAgICA1MktCCiAgICAgICogYXJt NjQtNjRLQiAgICAgODE5MiAgICAgNjRLQiAgICAgICAgICAgICAgIDY0S0IKICAgICAgKi8KICAg ICAjZGVmaW5lIE1FTV9URVNUX01PVkVfU0laRQkweDQwMDAwICAgICAgICAgICAvKiAyNTZLQiAq LwoKKDIpIEluIHRoZSBuZXh0IHBhdGNoLCB3aGVyZSB3ZSBoYXZlICg1MTJNQis2NEtCKSBhZnRl ciB0aGUgdmFyaW91cwogICAgIG1lbW9yeSBzaXplcyBhcmUgY29uc29saWRhdGVkLCBJdCBpcyBh ZGp1c3RlZCBhY2NvcmRpbmdseSBhcyBiZWxvdy4KCiAgICAgLyoKICAgICAgKiBXZSBoYXZlIGRp ZmZlcmVudCBudW1iZXIgb2YgbWVtb3J5IHNsb3RzLCBleGNsdWRpbmcgdGhlIHJlc2VydmVkCiAg ICAgICogbWVtb3J5IHNsb3QgMCwgb24gdmFyaW91cyBhcmNoaXRlY3R1cmVzIGFuZCBjb25maWd1 cmF0aW9ucy4gVGhlCiAgICAgICogbWVtb3J5IHNpemUgaW4gdGhpcyB0ZXN0IGlzIGNhbGN1bGF0 ZWQgYnkgZG91YmxpbmcgdGhlIG1heGltYWwKICAgICAgKiBtZW1vcnkgc2l6ZSBpbiBsYXN0IG1l bW9yeSBzbG90LCB3aXRoIGFsaWdubWVudCB0byB0aGUgbGFyZ2VzdAogICAgICAqIHN1cHBvcnRl ZCBwYWdlIHNpemUgKDY0S0IpLgogICAgICAqCiAgICAgICogYXJjaGl0ZWN0dXJlICAgc2xvdHMg ICAgbWVtb3J5LXBlci1zbG90ICAgIG1lbW9yeS1vbi1sYXN0LXNsb3QKICAgICAgKiAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQog ICAgICAqIHg4Ni00S0IgICAgICAgIDMyNzYzICAgIDE2S0IgICAgICAgICAgICAgICAxNjBLQgog ICAgICAqIGFybTY0LTRLQiAgICAgIDMyNzY2ICAgIDE2S0IgICAgICAgICAgICAgICAxMTJLQgog ICAgICAqIGFybTY0LTY0S0IgICAgIDgxOTIgICAgIDY0S0IgICAgICAgICAgICAgICAxMjhLQgog ICAgICAqLwogICAgICNkZWZpbmUgTUVNX1RFU1RfTU9WRV9TSVpFCTB4NTAwMDAgICAgICAgICAg IC8qIDMyMEtCICovCgpUaGFua3MsCkdhdmluCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5j b2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5m by9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 025257E for ; Wed, 19 Oct 2022 00:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666139191; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2iRn13iSXiKN1tasBVGZtH8JeAlfEonkeX/dLbbng1k=; b=iUhRaShlmmIdSVo9an2mkZi+zFcstqJzBUhpMZ8J7g0fDvQkWhRIoDOszcTtZ/4rI7HKQF iU8s5EgqjwJuw1wcF8CzrEWzUBuGIRalbolOneMsyOWyfEN94XDNBN88dUbvMtnE0/N8gb edbgnQ/u/Ndw2Teaubt8RP1gP+Nfgac= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-141-y8oaFLu7N5emg5q9o1-lYw-1; Tue, 18 Oct 2022 20:26:28 -0400 X-MC-Unique: y8oaFLu7N5emg5q9o1-lYw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C8A1F3C01E0A; Wed, 19 Oct 2022 00:26:27 +0000 (UTC) Received: from [10.64.54.70] (vpn2-54-70.bne.redhat.com [10.64.54.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 506502028DC1; Wed, 19 Oct 2022 00:26:22 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH 4/6] KVM: selftests: memslot_perf_test: Support variable guest page size To: "Maciej S. Szmigiero" Cc: kvm@vger.kernel.org, maz@kernel.org, linux-kernel@vger.kernel.org, zhenyzha@redhat.com, shan.gavin@gmail.com, kvmarm@lists.linux.dev, pbonzini@redhat.com, shuah@kernel.org, kvmarm@lists.cs.columbia.edu, ajones@ventanamicro.com References: <20221014071914.227134-1-gshan@redhat.com> <20221014071914.227134-5-gshan@redhat.com> <3eecebca-a526-d10a-02d3-496ce919d577@maciej.szmigiero.name> From: Gavin Shan Message-ID: <5bfbe050-a654-8400-e1f1-dcfa4dba13e6@redhat.com> Date: Wed, 19 Oct 2022 08:26:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Message-ID: <20221019002619.BrxBLKQi2wmvw4a_P99EMY7fMDCeYhHJb7WjM6eJaOw@z> On 10/18/22 11:56 PM, Maciej S. Szmigiero wrote: > On 18.10.2022 02:51, Gavin Shan wrote: >> On 10/18/22 8:46 AM, Gavin Shan wrote: >>> On 10/18/22 5:31 AM, Maciej S. Szmigiero wrote: >>>> On 14.10.2022 09:19, Gavin Shan wrote: >>>>> The test case is obviously broken on aarch64 because non-4KB guest >>>>> page size is supported. The guest page size on aarch64 could be 4KB, >>>>> 16KB or 64KB. >>>>> >>>>> This supports variable guest page size, mostly for aarch64. >>>>> >>>>>    - The host determines the guest page size when virtual machine is >>>>>      created. The value is also passed to guest through the synchronization >>>>>      area. >>>>> >>>>>    - The number of guest pages are unknown until the virtual machine >>>>>      is to be created. So all the related macros are dropped. Instead, >>>>>      their values are dynamically calculated based on the guest page >>>>>      size. >>>>> >>>>>    - The static checks on memory sizes and pages becomes dependent >>>>>      on guest page size, which is unknown until the virtual machine >>>>>      is about to be created. So all the static checks are converted >>>>>      to dynamic checks, done in check_memory_sizes(). >>>>> >>>>>    - As the address passed to madvise() should be aligned to host page, >>>>>      the size of page chunk is automatically selected, other than one >>>>>      page. >>>>> >>>>>    - All other changes included in this patch are almost mechanical >>>>>      replacing '4096' with 'guest_page_size'. >>>>> >>>>> Signed-off-by: Gavin Shan >>>>> --- >>>>>   .../testing/selftests/kvm/memslot_perf_test.c | 191 +++++++++++------- >>>>>   1 file changed, 115 insertions(+), 76 deletions(-) >>>>> >>>>> diff --git a/tools/testing/selftests/kvm/memslot_perf_test.c b/tools/testing/selftests/kvm/memslot_perf_test.c >>>>> index d5aa9148f96f..d587bd952ff9 100644 >>>>> --- a/tools/testing/selftests/kvm/memslot_perf_test.c >>>>> +++ b/tools/testing/selftests/kvm/memslot_perf_test.c > (...) >>>>> @@ -77,8 +61,7 @@ static_assert(MEM_TEST_UNMAP_SIZE_PAGES % >>>>>    * for the total size of 25 pages. >>>>>    * Hence, the maximum size here is 50 pages. >>>>>    */ >>>>> -#define MEM_TEST_MOVE_SIZE_PAGES    (50) >>>>> -#define MEM_TEST_MOVE_SIZE        (MEM_TEST_MOVE_SIZE_PAGES * 4096) >>>>> +#define MEM_TEST_MOVE_SIZE        0x32000 >>>> >>>> The above number seems less readable than an explicit value of 50 pages. >>>> >>>> In addition to that, it's 50 pages only with 4k page size, so at least >>>> the comment above needs to be updated to reflect this fact. >>>> >>> >>> Yeah, I will change the comments like below in next revision. >>> >>>   /* >>>    * When running this test with 32k memslots, actually 32763 excluding >>>    * the reserved memory slot 0, the memory for each slot is 0x4000 bytes. >>>    * The last slot contains 0x19000 bytes memory. Hence, the maximum size >>>    * here is 0x32000 bytes. >>>    */ >>> >> >> I will replace those numbers with readable ones like below :) >> >> /* >>   * When running this test with 32k memslots, actually 32763 excluding >>   * the reserved memory slot 0, the memory for each slot is 16KB. The >>   * last slot contains 100KB memory with the remaining 84KB. Hence, >>   * the maximum size is double of that (200KB) >>   */ > > Still, these numbers are for x86, which has KVM_INTERNAL_MEM_SLOTS > defined as 3. > > As far as I can see aarch64 has KVM_INTERNAL_MEM_SLOTS equal to 0, so > this arch has 32766 slot available for the test memory. > > Quick calculations show that this will result in 112 KiB of memory in > the last slot for 4 KiB page size (while for 64 KiB page size the > maximum slot count for this test is 8192 anyway - not counting slot 0). > It seems your calculation had (512MB+64KB), instead of (512MB+4KB). In this particular patch, we still have (512MB+4KB). How about to change like below in this patch. In next patch, it's adjusted accordingly after we have (512MB+64KB). (1) In this patch, the comment is changed to as below /* * We have different number of memory slots, excluding the reserved * memory slot 0, on various architectures and configurations. The * memory size in this test is calculated by doubling the maximal * memory size in last memory slot, with alignment to the largest * supported page size (64KB). * * architecture slots memory-per-slot memory-on-last-slot * -------------------------------------------------------------- * x86-4KB 32763 16KB 100KB * arm64-4KB 32766 16KB 52KB * arm64-64KB 8192 64KB 64KB */ #define MEM_TEST_MOVE_SIZE 0x40000 /* 256KB */ (2) In the next patch, where we have (512MB+64KB) after the various memory sizes are consolidated, It is adjusted accordingly as below. /* * We have different number of memory slots, excluding the reserved * memory slot 0, on various architectures and configurations. The * memory size in this test is calculated by doubling the maximal * memory size in last memory slot, with alignment to the largest * supported page size (64KB). * * architecture slots memory-per-slot memory-on-last-slot * -------------------------------------------------------------- * x86-4KB 32763 16KB 160KB * arm64-4KB 32766 16KB 112KB * arm64-64KB 8192 64KB 128KB */ #define MEM_TEST_MOVE_SIZE 0x50000 /* 320KB */ Thanks, Gavin