From: Marc Zyngier <maz@kernel.org>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] KVM: arm/arm64: vgic: Fix some comments typo
Date: Tue, 29 Oct 2019 09:04:34 +0000 [thread overview]
Message-ID: <86o8xzylb1.wl-maz@kernel.org> (raw)
In-Reply-To: <20191029071919.177-3-yuzenghui@huawei.com>
Hi Zenghui,
On Tue, 29 Oct 2019 07:19:18 +0000,
Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> s/vgic_its_save_pending_tables/vgic_v3_save_pending_tables/
> s/then/the/
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> include/kvm/arm_vgic.h | 2 +-
> virt/kvm/arm/vgic/vgic-v3.c | 2 +-
> virt/kvm/arm/vgic/vgic-v4.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
> index 0fb240ec0a2a..01f8b3739a09 100644
> --- a/include/kvm/arm_vgic.h
> +++ b/include/kvm/arm_vgic.h
> @@ -240,7 +240,7 @@ struct vgic_dist {
> * Contains the attributes and gpa of the LPI configuration table.
> * Since we report GICR_TYPER.CommonLPIAff as 0b00, we can share
> * one address across all redistributors.
> - * GICv3 spec: 6.1.2 "LPI Configuration tables"
> + * GICv3 spec "LPI Configuration tables"
Why the change here? Pointing to the chapter in the spec is pretty
helpful, given that it is 800 pages long (although it should mention
what revision of the spec this refers to). For example, it should say
something like "IHI 0069E 6.1.1 ...".
Thanks,
M.
--
Jazz is not dead, it just smells funny.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2019-10-29 9:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 7:19 [PATCH 0/3] KVM: arm/arm64: vgic: Some cleanups and fixes Zenghui Yu
2019-10-29 7:19 ` [PATCH 1/3] KVM: arm/arm64: vgic: Remove the declaration of kvm_send_userspace_msi() Zenghui Yu
2019-10-29 12:29 ` Auger Eric
2019-10-29 7:19 ` [PATCH 2/3] KVM: arm/arm64: vgic: Fix some comments typo Zenghui Yu
2019-10-29 9:04 ` Marc Zyngier [this message]
2019-10-29 12:45 ` Zenghui Yu
2019-10-29 13:22 ` Marc Zyngier
2019-10-29 7:19 ` [PATCH 3/3] KVM: arm/arm64: vgic: Don't rely on the wrong pending table Zenghui Yu
2019-10-29 9:23 ` Marc Zyngier
2019-10-29 12:27 ` Zenghui Yu
2019-10-29 12:49 ` Auger Eric
2019-10-29 13:31 ` Zenghui Yu
2019-10-29 22:52 ` Auger Eric
2019-10-29 12:17 ` Auger Eric
2019-10-29 12:30 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o8xzylb1.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).