From: Marc Zyngier <maz@kernel.org>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: kernel-team@android.com, lorenzo.pieralisi@arm.com,
justin.he@arm.com, kvm@vger.kernel.org, netdev@vger.kernel.org,
richardcochran@gmail.com, yangbo.lu@nxp.com,
sudeep.holla@arm.com, steven.price@arm.com,
Andre.Przywara@arm.com, john.stultz@linaro.org,
linux-arm-kernel@lists.infradead.org, seanjc@google.com,
pbonzini@redhat.com, tglx@linutronix.de, will@kernel.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v19 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64
Date: Sat, 17 Apr 2021 10:05:28 +0100 [thread overview]
Message-ID: <87wnt1s2lj.wl-maz@kernel.org> (raw)
In-Reply-To: <d85fc46b-2076-ee0b-ac73-f7a3f393d87f@huawei.com>
On Sat, 17 Apr 2021 09:42:37 +0100,
Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> On 2021/3/30 22:54, Marc Zyngier wrote:
> > +int kvm_arch_ptp_init(void)
> > +{
> > + int ret;
> > +
> > + ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_PTP);
> > + if (ret <= 0)
>
> kvm_arm_hyp_service_available() returns boolean. Maybe write as ?
>
> bool ret;
>
> ret = kvm_arm_hyp_service_available();
> if (!ret)
> return -ENODEV;
Fixed in 300bb1fe7671, as previously reported by Dan Carpenter in [1].
Thanks,
M.
https://lore.kernel.org/r/20210331043704.GG2065@kadam
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2021-04-17 9:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 14:54 [PATCH v19 0/7] KVM: arm64: Add host/guest KVM-PTP support Marc Zyngier
2021-03-30 14:54 ` [PATCH v19 1/7] arm/arm64: Probe for the presence of KVM hypervisor Marc Zyngier
2021-04-17 9:49 ` Zenghui Yu
2021-03-30 14:54 ` [PATCH v19 2/7] KVM: arm64: Advertise KVM UID to guests via SMCCC Marc Zyngier
2021-03-30 14:54 ` [PATCH v19 3/7] ptp: Reorganize ptp_kvm.c to make it arch-independent Marc Zyngier
2021-04-07 9:28 ` Marc Zyngier
2021-04-07 15:13 ` Richard Cochran
2021-04-07 15:31 ` Marc Zyngier
2021-03-30 14:54 ` [PATCH v19 4/7] time: Add mechanism to recognize clocksource in time_get_snapshot Marc Zyngier
2021-04-17 9:27 ` Zenghui Yu
2021-03-30 14:54 ` [PATCH v19 5/7] clocksource: Add clocksource id for arm arch counter Marc Zyngier
2021-03-30 14:54 ` [PATCH v19 6/7] KVM: arm64: Add support for the KVM PTP service Marc Zyngier
2021-04-17 8:59 ` Zenghui Yu
2021-04-17 9:10 ` Marc Zyngier
2021-04-17 10:24 ` Zenghui Yu
2021-03-30 14:54 ` [PATCH v19 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64 Marc Zyngier
2021-04-17 8:42 ` Zenghui Yu
2021-04-17 9:05 ` Marc Zyngier [this message]
2021-05-11 9:07 ` Geert Uytterhoeven
2021-05-11 9:13 ` Marc Zyngier
2021-05-26 7:52 ` Geert Uytterhoeven
2021-05-26 8:01 ` Marc Zyngier
2021-05-26 8:18 ` Geert Uytterhoeven
2021-05-26 8:32 ` Marc Zyngier
2021-05-26 8:50 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnt1s2lj.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Andre.Przywara@arm.com \
--cc=john.stultz@linaro.org \
--cc=justin.he@arm.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=richardcochran@gmail.com \
--cc=seanjc@google.com \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=yangbo.lu@nxp.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).