From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 949B1C2BB1D for ; Tue, 7 Apr 2020 11:24:53 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 0D5252051A for ; Tue, 7 Apr 2020 11:24:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EbXmjYLX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D5252051A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 601954B16F; Tue, 7 Apr 2020 07:24:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@linaro.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bI69vLejNwgC; Tue, 7 Apr 2020 07:24:51 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 52A444B13F; Tue, 7 Apr 2020 07:24:51 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4A8C84B11B for ; Tue, 7 Apr 2020 07:24:50 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id llfXEUD54yQC for ; Tue, 7 Apr 2020 07:24:49 -0400 (EDT) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4FC534B0BB for ; Tue, 7 Apr 2020 07:24:49 -0400 (EDT) Received: by mail-ot1-f65.google.com with SMTP id x11so2693916otp.6 for ; Tue, 07 Apr 2020 04:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vnASXYJpk92WfwXwrbznymfvmBuY/sr1MK3eKQbxoXM=; b=EbXmjYLXGFUiUbEFtAJaqtqhT8nbqdKnXm7EOymQju+AN8pQQ7Ef53P0WOOAz16/PG Dwd+qvFdFskuTztzBDkxAQ8oIOAUb5IOCREHuwCc6T1J6BjZ3E83XY0BC0gbQA7anguE 7equgXH3Dlk69uqnIdhQCFtIory02zJbM6DSdr6koV4uIad58tXvm86vsgIhf4svgyaA ct+y1lHmlF399tLELCzzLxND8iNu7DFOfzbTskxZSIXqWJqXMRTa9gSt+hJrbMpNbFCX 8E7wC/KDBPfnUiuIg3eBSQ1K7PfcTt+X8u5cOccwt+9o5HveC1KRIzcSuC4dwrz32k8j gnug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vnASXYJpk92WfwXwrbznymfvmBuY/sr1MK3eKQbxoXM=; b=QoTk8INv25h5TR66OWF4UZDclMopVDFynKjwT5EDWtrMp6bPlNDWPoh18T2nMpoQjZ 2YBjoBx6zDf+R26koVX09tKmLwp8UTYEjuMDlBKsxntCPZ+zs1KkFquo5NH6V21aCJlD 4IJiT49RibXRatrYtC6nJ/JUgr2PAjv5tANWhorXNYO23j/2BB4UURjj6YEJqeMV0ob0 1VZq3KATHRuu482yb25NsBHNaVujR7IGbZBhPoqsmxGr3Rn4Yg1sIRQ0ZhngkfMAP/Uv ut26MbBTQjXSFzi/5LeUTx+Y2yGMltyW7ka9PFPcv2wU6iS+HIBrwbaDyQf6C9PaOkeA Gg4g== X-Gm-Message-State: AGi0PuZauJFJGrYK4R+e8t0JVdcOq3KggIZFpgxOsntnBldV10flRaHO IDGg/Zq1FyquPh+ZcMg4LA3Rrshe4Xb4Y9GvJ44IQg== X-Google-Smtp-Source: APiQypLWArKPOw0PZD0smR06050zJ9zXEwIyOsNwy140j1L7le0lK5rWjGL3mSPfonZ9BgjeU4/rxN8//gDG9fPJWLw= X-Received: by 2002:a4a:2a09:: with SMTP id k9mr1439312oof.64.1586258688530; Tue, 07 Apr 2020 04:24:48 -0700 (PDT) MIME-Version: 1.0 References: <20200323113227.3169-1-beata.michalska@linaro.org> <20200323113227.3169-3-beata.michalska@linaro.org> <20200403084435.zvfewiivn7orsnll@kamzik.brq.redhat.com> In-Reply-To: <20200403084435.zvfewiivn7orsnll@kamzik.brq.redhat.com> From: Peter Maydell Date: Tue, 7 Apr 2020 12:24:37 +0100 Message-ID: Subject: Re: [PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection To: Andrew Jones Cc: QEMU Developers , qemu-arm , Paolo Bonzini , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, 3 Apr 2020 at 09:44, Andrew Jones wrote: > > On Mon, Mar 23, 2020 at 11:32:27AM +0000, Beata Michalska wrote: > > Injecting external data abort through KVM might trigger > > an issue on kernels that do not get updated to include the KVM fix. > > For those and aarch32 guests, the injected abort gets misconfigured > > to be an implementation defined exception. This leads to the guest > > repeatedly re-running the faulting instruction. > > > > Add support for handling that case. > > [ > > Fixed-by: 018f22f95e8a > > ('KVM: arm: Fix DFSR setting for non-LPAE aarch32 guests') > > Fixed-by: 21aecdbd7f3a > > ('KVM: arm: Make inject_abt32() inject an external abort instead') > > ] > > > I'll leave the decision to take this KVM bug workaround patch at all to Peter, > and I didn't actually review whether or not kvm_arm_verify_ext_dabt_pending > is doing what it claims it's doing, so I'm reluctant to give an r-b on > this patch. But, as far as the code goes, besides the comments above, it > looks fine to me. I think that having the workaround for the broken kernels is reasonable (in fact it might have been my suggestion). thanks -- PMM _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm