From: Raghavendra Rao Ananta <rananta@google.com>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Peter Shier <pshier@google.com>,
linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 12/15] KVM: arm64: selftests: Add basic GICv3 support
Date: Mon, 4 Oct 2021 11:26:57 -0700 [thread overview]
Message-ID: <CAJHc60yXKdCCpSejxwGpmqoTenm=3589+ahmzkLkSnmy89+YLQ@mail.gmail.com> (raw)
In-Reply-To: <ab2a7213-1857-6761-594d-958af864a23a@huawei.com>
On Thu, Sep 30, 2021 at 1:06 AM Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> On 2021/9/15 6:31, Raghavendra Rao Ananta wrote:
> > +static inline void *gicr_base_gpa_cpu(void *redist_base, uint32_t cpu)
> > +{
> > + /* Align all the redistributors sequentially */
> > + return redist_base + cpu * SZ_64K * 2;
> > +}
> > +
> > +static void gicv3_cpu_init(unsigned int cpu, void *redist_base)
> > +{
> > + void *sgi_base;
> > + unsigned int i;
> > + void *redist_base_cpu;
> > +
> > + GUEST_ASSERT(cpu < gicv3_data.nr_cpus);
> > +
> > + redist_base_cpu = gicr_base_gpa_cpu(redist_base, cpu);
>
> This is not 'gpa' and I'd rather open-code it directly as there's
> just a single caller.
>
> Zenghui
Thanks for catching this. I agree that mentioning 'gpa' oddballs this
function, since it's called from a guest's point of view. If there are
any other major changes in the series, I'll try to change this as
well. Else, I will try to raise a separate patch to resolve this.
Regards,
Raghavendra
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2021-10-04 18:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 22:30 [PATCH v7 00/15] KVM: arm64: selftests: Introduce arch_timer selftest Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 01/15] KVM: arm64: selftests: Add MMIO readl/writel support Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 02/15] tools: arm64: Import sysreg.h Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 03/15] KVM: arm64: selftests: Use read/write definitions from sysreg.h Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 04/15] KVM: arm64: selftests: Introduce ARM64_SYS_KVM_REG Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 05/15] KVM: arm64: selftests: Add support for cpu_relax Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 06/15] KVM: arm64: selftests: Add basic support for arch_timers Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 07/15] KVM: arm64: selftests: Add basic support to generate delays Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 08/15] KVM: arm64: selftests: Add support to disable and enable local IRQs Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 09/15] KVM: arm64: selftests: Maintain consistency for vcpuid type Raghavendra Rao Ananta
2021-09-15 5:54 ` Andrew Jones
2021-09-14 22:31 ` [PATCH v7 10/15] KVM: arm64: selftests: Add guest support to get the vcpuid Raghavendra Rao Ananta
2021-09-15 5:55 ` Andrew Jones
2021-09-14 22:31 ` [PATCH v7 11/15] KVM: arm64: selftests: Add light-weight spinlock support Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 12/15] KVM: arm64: selftests: Add basic GICv3 support Raghavendra Rao Ananta
2021-09-30 8:06 ` Zenghui Yu
2021-10-04 18:26 ` Raghavendra Rao Ananta [this message]
2021-09-14 22:31 ` [PATCH v7 13/15] KVM: arm64: selftests: Add host support for vGIC Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 14/15] KVM: arm64: selftests: Add arch_timer test Raghavendra Rao Ananta
2021-09-14 22:31 ` [PATCH v7 15/15] KVM: arm64: selftests: arch_timer: Support vCPU migration Raghavendra Rao Ananta
2021-09-30 9:41 ` Zenghui Yu
2021-10-04 18:23 ` Raghavendra Rao Ananta
2021-09-28 17:02 ` [PATCH v7 00/15] KVM: arm64: selftests: Introduce arch_timer selftest Raghavendra Rao Ananta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJHc60yXKdCCpSejxwGpmqoTenm=3589+ahmzkLkSnmy89+YLQ@mail.gmail.com' \
--to=rananta@google.com \
--cc=catalin.marinas@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).