From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED8FC43331 for ; Fri, 8 Nov 2019 02:52:00 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 5458521882 for ; Fri, 8 Nov 2019 02:52:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="raumMO49"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="raumMO49" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5458521882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B11C84AEC5; Thu, 7 Nov 2019 21:51:59 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, body has been altered) header.i=@armh.onmicrosoft.com Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, body has been altered) header.i=@armh.onmicrosoft.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vAMMAmEaThLf; Thu, 7 Nov 2019 21:51:58 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 63F4C4AECB; Thu, 7 Nov 2019 21:51:58 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C6CBE4AEC5 for ; Thu, 7 Nov 2019 21:51:57 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y3NcEIPna9q4 for ; Thu, 7 Nov 2019 21:51:56 -0500 (EST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10046.outbound.protection.outlook.com [40.107.1.46]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 20D6A4AEC4 for ; Thu, 7 Nov 2019 21:51:56 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BdTY0JbhkY6/6eskSvqk2yfJ3IFG65hthmmAev67c2w=; b=raumMO49Ya+iI7QERym2Udjz/EuNaJD74/vYPiyhuIbUctYbK+GJyciCRjRCuNFKZj74JQWB1hKZoxCbHmXfSbELYH8BB8/zVaDMq8peYYiSDL9irxgLFM9DKUr18uljosJu4LWtgPq/xUaOmAY5FNXJxrmASkViB4EkyUB47u0= Received: from VI1PR0802CA0025.eurprd08.prod.outlook.com (2603:10a6:800:a9::11) by AM6PR08MB3350.eurprd08.prod.outlook.com (2603:10a6:209:45::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Fri, 8 Nov 2019 02:51:53 +0000 Received: from AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::206) by VI1PR0802CA0025.outlook.office365.com (2603:10a6:800:a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2430.20 via Frontend Transport; Fri, 8 Nov 2019 02:51:53 +0000 Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.cs.columbia.edu; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.cs.columbia.edu; dmarc=none action=none header.from=arm.com; Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT044.mail.protection.outlook.com (10.152.17.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2430.21 via Frontend Transport; Fri, 8 Nov 2019 02:51:53 +0000 Received: ("Tessian outbound 851a1162fca7:v33"); Fri, 08 Nov 2019 02:51:51 +0000 X-CR-MTA-TID: 64aa7808 Received: from ebff76385b05.2 (cr-mta-lb-1.cr-mta-net [104.47.4.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9EA17CD6-723F-47F5-95A8-1B85579A6C74.1; Fri, 08 Nov 2019 02:51:46 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2056.outbound.protection.outlook.com [104.47.4.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ebff76385b05.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Nov 2019 02:51:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U6DVogRnMm2XlW2YryYoDspufVFhEGFBiTI5hTCaeyb+ddVtlkQDD0tfvEf9KRHsaFGJNSGAGFJWQ6raRWBhI/7DqdkrS0z6QvFor32IZpLDU4yp43v30sQCR2cxWtnrWFqxFjwQvyWy/T+mVkykkVY0R4Gk4Oiqdhvew1sRTqmUY7rlefoFOpwieu2gB2P7xUkQmUu2BMaQ9UZhWHOgnzQ/MwXf7aiHq7rb/GyVydeYlbFhUTGGyFQT5o7sY0h38zN/lf/TfZnwOF1aYNoXwKY1mNKQ/IFNMUvvU7SHtZqx/oxAEboH6cNlfwQz5cBXuzDHdbdRkeIXkayUbPdBcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BdTY0JbhkY6/6eskSvqk2yfJ3IFG65hthmmAev67c2w=; b=iMB8mpRykImGGNF5hXhC7SoDWc7yTkLJlOCAaOsmpn+ck6Qb6yxkBZWsLW/OXXDUyOrJKV4m6iOn7nZumt/pcY7QjnJDQCh+5rMAjRrNZC+0v1y6rOfxldqdb4Q/jTTjF5F3tBhnBJqTqHJZBKTFgL77/iW+Qxwfoxe50XCGpRhhEdk9ZTmd5imvA5BeEd10/ekbixeJItUfwrAjgodgkzyhTJpHCUqNNfBS2guu1odxwOuBQLP9UfnMGo5XowudAVYekqmATjr2CLQ4t3vByJZRFQXfPsKrcwcrjWWCLZMHvNuar7LzwSPorI0aKDdyX4qREDsRnR+LRefIZbU41A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BdTY0JbhkY6/6eskSvqk2yfJ3IFG65hthmmAev67c2w=; b=raumMO49Ya+iI7QERym2Udjz/EuNaJD74/vYPiyhuIbUctYbK+GJyciCRjRCuNFKZj74JQWB1hKZoxCbHmXfSbELYH8BB8/zVaDMq8peYYiSDL9irxgLFM9DKUr18uljosJu4LWtgPq/xUaOmAY5FNXJxrmASkViB4EkyUB47u0= Received: from HE1PR0801MB1676.eurprd08.prod.outlook.com (10.168.146.150) by HE1PR0801MB1690.eurprd08.prod.outlook.com (10.168.145.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Fri, 8 Nov 2019 02:51:44 +0000 Received: from HE1PR0801MB1676.eurprd08.prod.outlook.com ([fe80::453c:d9b6:5398:2294]) by HE1PR0801MB1676.eurprd08.prod.outlook.com ([fe80::453c:d9b6:5398:2294%8]) with mapi id 15.20.2430.023; Fri, 8 Nov 2019 02:51:44 +0000 From: "Jianyong Wu (Arm Technology China)" To: Thomas Gleixner Subject: RE: [RFC PATCH v6 5/7] psci: Add hvc call service for ptp_kvm. Thread-Topic: [RFC PATCH v6 5/7] psci: Add hvc call service for ptp_kvm. Thread-Index: AQHVilqZVMoUcaXKbE+vr/6AIRo8jKd/bmYAgAE3LOA= Date: Fri, 8 Nov 2019 02:51:44 +0000 Message-ID: References: <20191024110209.21328-1-jianyong.wu@arm.com> <20191024110209.21328-6-jianyong.wu@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 90748d83-4bdb-4ee3-aed4-fb4cce270c7c.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Jianyong.Wu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 160db941-ab12-4429-75a9-08d763f69c41 X-MS-TrafficTypeDiagnostic: HE1PR0801MB1690:|HE1PR0801MB1690:|AM6PR08MB3350: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; x-forefront-prvs: 0215D7173F X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(13464003)(189003)(199004)(5660300002)(81156014)(6436002)(6916009)(99286004)(55016002)(74316002)(186003)(2906002)(66556008)(6246003)(4326008)(446003)(14444005)(102836004)(476003)(26005)(25786009)(66476007)(86362001)(229853002)(478600001)(14454004)(3846002)(55236004)(256004)(6116002)(52536014)(76176011)(7736002)(7696005)(33656002)(7416002)(316002)(11346002)(54906003)(486006)(53546011)(6506007)(9686003)(66066001)(64756008)(76116006)(66946007)(305945005)(8936002)(66446008)(81166006)(8676002)(71190400001)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1690; H:HE1PR0801MB1676.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Mz3B7tgT2kLk+3X18+7ilYUfs/eJ7lPDIUpwZloBt4yrhDBr8+ZwtNlYp/RfG4m44QyEIdoYob2PjeiVRyG+GDMEbWFlYXRJvmycV94T0ULTIvsdl4Qp6q55XdUlt1s08YRJ0dzhkw/TtL0P/n+mL7JNIhsrgtCXkdvs/BhScjNyHT42HfO9y5ApjNBf8PM8IuVn2sTbf8fd4JWXzF0bzwjbq05cx49glvS6pdvdscpnEKe1r8mccPOo7xQ0kwu04XWGwep/4gkzwRj2hBrlJ98IKEl3XN/qox79Kn6fqb+yF7VidN1aMW1NPa+AN2voq0kx/KM+/sTcLVAtyTjhkh2d/B1M27eijD1I7gd4b3U708bwS6+yZbYqpwGXS8b5YvrDxOSeAH1vHpTRuYYQb1xkJbTJZ871zAKtc6MFMV5qUqwP1G+XWs5wyUe4v0We MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1690 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jianyong.Wu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(39860400002)(396003)(136003)(1110001)(339900001)(13464003)(189003)(199004)(74316002)(46406003)(356004)(7696005)(186003)(76176011)(229853002)(7736002)(6246003)(14444005)(22756006)(4326008)(105606002)(305945005)(55016002)(70586007)(446003)(11346002)(9686003)(52536014)(76130400001)(70206006)(5660300002)(26005)(6116002)(8746002)(54906003)(486006)(23726003)(81156014)(99286004)(6862004)(8676002)(81166006)(2906002)(8936002)(36906005)(476003)(14454004)(26826003)(102836004)(33656002)(53546011)(6506007)(3846002)(336012)(478600001)(316002)(97756001)(47776003)(25786009)(50466002)(126002)(86362001)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3350; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 87832ef8-58bd-44d4-5366-08d763f696f8 NoDisclaimer: True X-Forefront-PRVS: 0215D7173F X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KU2QmenWjrlZOeLbiHW36c49VDytqJLrbaJNtXM2qzDkMawdffNKGwiqZBpWdI3ZtdNvXIKrepBzx+mY1ClWzVAC/GXSJ6v17YLwNW6N8Ufp7uXrSEvB+EJeBkLzn1YuqIui64ijlpfRe4ckxRT+I5iiaIhZfN4mZn9tpVWSRuwFS2XQnPweNfd02zHlpfChRUrvgjw6/Tw630nVBosK6YLv9JGiPNfV/Dpb56SEtH4VZ97HMvzelTa1gSxS4jbNGe02hQzF08YhZPDvgISEbNOQhf3P5WDCnEp7NJPGhYxURo/H2SiPTY2kN8mhNZ8V4gMwF/HdF8gT+xqGnVE349uDca1VKjHTIyjSA28rkZXSgLkNQS6WKTsG/ai0buLi/GZg5UdKxwSqt7lTCiyBG17pZ86cBBuIye8m5lurHGD3iX7tsDs57yuOa2ntpxud X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2019 02:51:53.0224 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 160db941-ab12-4429-75a9-08d763f69c41 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3350 Cc: "Justin He \(Arm Technology China\)" , "kvm@vger.kernel.org" , "maz@kernel.org" , "richardcochran@gmail.com" , "yangbo.lu@nxp.com" , "linux-kernel@vger.kernel.org" , "sean.j.christopherson@intel.com" , "john.stultz@linaro.org" , "netdev@vger.kernel.org" , "pbonzini@redhat.com" , nd , "will@kernel.org" , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi tglx, > -----Original Message----- > From: Thomas Gleixner > Sent: Thursday, November 7, 2019 4:01 PM > To: Jianyong Wu (Arm Technology China) > Cc: netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org; > pbonzini@redhat.com; sean.j.christopherson@intel.com; maz@kernel.org; > richardcochran@gmail.com; Mark Rutland ; > will@kernel.org; Suzuki Poulose ; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org; Steve Capper > ; Kaly Xin (Arm Technology China) > ; Justin He (Arm Technology China) > ; nd > Subject: Re: [RFC PATCH v6 5/7] psci: Add hvc call service for ptp_kvm. > > On Thu, 24 Oct 2019, Jianyong Wu wrote: > > > This patch is the base of ptp_kvm for arm64. > > This patch ... > Yeah, avoid subjective expression. > > ptp_kvm modules will call hvc to get this service. > > The service offers real time and counter cycle of host for guest. > > > > Signed-off-by: Jianyong Wu > > --- > > drivers/clocksource/arm_arch_timer.c | 2 ++ > > include/clocksource/arm_arch_timer.h | 4 ++++ > > include/linux/arm-smccc.h | 12 ++++++++++++ > > virt/kvm/arm/psci.c | 22 ++++++++++++++++++++++ > > 4 files changed, 40 insertions(+) > > > > diff --git a/drivers/clocksource/arm_arch_timer.c > > b/drivers/clocksource/arm_arch_timer.c > > index 07e57a49d1e8..e4ad38042ef6 100644 > > --- a/drivers/clocksource/arm_arch_timer.c > > +++ b/drivers/clocksource/arm_arch_timer.c > > @@ -29,6 +29,7 @@ > > #include > > > > #include > > +#include > > Same ordering issue and lack of file. > OK, > > diff --git a/include/clocksource/arm_arch_timer.h > > b/include/clocksource/arm_arch_timer.h > > index 1d68d5613dae..426d749e8cf8 100644 > > --- a/include/clocksource/arm_arch_timer.h > > +++ b/include/clocksource/arm_arch_timer.h > > @@ -104,6 +104,10 @@ static inline bool > arch_timer_evtstrm_available(void) > > return false; > > } > > > > +bool is_arm_arch_counter(void *unuse) > > A global function in a header file? You might want to make this static inline. > And while at it please s/unuse/unused/ > Should remove this residue line from v5 in v6. > > +{ > > + return false; > > +} > > #endif > > #include > > diff --git a/virt/kvm/arm/psci.c b/virt/kvm/arm/psci.c index > > 0debf49bf259..339bcbafac7b 100644 > > --- a/virt/kvm/arm/psci.c > > +++ b/virt/kvm/arm/psci.c > > @@ -15,6 +15,7 @@ > > #include > > > > #include > > +#include > > Sigh. > Yeah, > > /* > > * This is an implementation of the Power State Coordination > > Interface @@ -392,6 +393,8 @@ int kvm_hvc_call_handler(struct > kvm_vcpu *vcpu) > > u32 func_id = smccc_get_function(vcpu); > > u32 val[4] = {}; > > u32 option; > > + u64 cycles; > > + struct system_time_snapshot systime_snapshot; > > Also here you might notice that the variables are not randomly ordered. > Do you mean considering the alignment then put "struct system_time_snapshot systime_snapshot" as the top one and u64 cycles as the second? Thanks Jianyong > Thanks, > > tglx _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm