From: Marc Zyngier <maz@kernel.org>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: KarimAllah Ahmed <karahmed@amazon.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] KVM: arm64: Use the correct timer for accessing CNT
Date: Mon, 16 Mar 2020 11:09:03 +0000 [thread overview]
Message-ID: <a8b72d6c0a28e0554050e98d011f32d9@kernel.org> (raw)
In-Reply-To: <7ed91b9b-e968-770c-28f9-0ca479359657@huawei.com>
Hi Zenghui,
On 2020-03-16 10:49, Zenghui Yu wrote:
> Hi,
>
> On 2020/3/16 17:39, KarimAllah Ahmed wrote:
>> Use the physical timer object when reading the physical timer counter
>> instead of using the virtual timer object. This is only visible when
>> reading it from user-space as kvm_arm_timer_get_reg() is only executed
>> on
>> the get register patch from user-space.
>
> s/patch/path/
>
> I think the physical counter hasn't yet been accessed by the current
> userspace, wrong?
I don't think userspace can access it, as the ONE_REG API only exposes
the virtual
timer so far, and userspace is much better off just reading the counter
directly
(it has access to the virtual counter, and the guarantee that cntvoff is
0 in this
context).
But as we move towards a situation where we can save/restore the
physical timer
just like the virtual one, we're going to use this path and hit this
bug.
>
>>
>> Cc: Marc Zyngier <maz@kernel.org>
>> Cc: James Morse <james.morse@arm.com>
>> Cc: Julien Thierry <julien.thierry.kdev@gmail.com>
>> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: kvmarm@lists.cs.columbia.edu
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>
>
> Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
>
> And this might also deserve:
>
> Fixes: 84135d3d18da ("KVM: arm/arm64: consolidate arch timer trap
> handlers")
Indeed. Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-03-16 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 9:39 [PATCH] KVM: arm64: Use the correct timer for accessing CNT KarimAllah Ahmed
2020-03-16 10:49 ` Zenghui Yu
2020-03-16 11:09 ` Marc Zyngier [this message]
2020-03-16 12:38 ` Zenghui Yu
2020-03-17 13:59 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8b72d6c0a28e0554050e98d011f32d9@kernel.org \
--to=maz@kernel.org \
--cc=karahmed@amazon.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).