kvmarm.lists.cs.columbia.edu archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Quentin Perret <qperret@google.com>
Cc: kernel-team@android.com, catalin.marinas@arm.com,
	linux-kernel@vger.kernel.org, will@kernel.org,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/7] KVM: arm64: Unify MMIO and mem host stage-2 pools
Date: Sun, 06 Jun 2021 11:31:20 +0100	[thread overview]
Message-ID: <b4e4647166447d8fd22b360369de4acb@kernel.org> (raw)
In-Reply-To: <20210602094347.3730846-5-qperret@google.com>

On 2021-06-02 10:43, Quentin Perret wrote:
> We currently maintain two separate memory pools for the host stage-2,
> one for pages used in the page-table when mapping memory regions, and
> the other to map MMIO regions. The former is large enough to map all of
> memory with page granularity and the latter can cover an arbitrary
> portion of IPA space, but allows to 'recycle' pages.
> 
> However, this split makes accounting difficult to manage as pages at
> intermediate levels of the page-table may be used to map both memory 
> and
> MMIO regions. Simplify the scheme by merging both pools into one. This
> means we can now hit the -ENOMEM case in the memory abort path, but
> we're still guaranteed forward-progress in the worst case by unmapping
> MMIO regions. On the plus side this also means we can usually map a lot
> more MMIO space at once if memory ranges happen to be mapped with block
> mappings.
> 
> Signed-off-by: Quentin Perret <qperret@google.com>

This patch fails to apply on top of -rc4. Did you use some more exotic
base or, as I suspect, a development tree?

Please check and respin the series if necessary.

         M.
-- 
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

  reply	other threads:[~2021-06-06 10:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02  9:43 [PATCH v2 0/7] KVM: arm64: Reduce hyp_vmemmap overhead Quentin Perret
2021-06-02  9:43 ` [PATCH v2 1/7] KVM: arm64: Move hyp_pool locking out of refcount helpers Quentin Perret
2021-06-02  9:43 ` [PATCH v2 2/7] KVM: arm64: Use refcount at hyp to check page availability Quentin Perret
2021-06-02  9:43 ` [PATCH v2 3/7] KVM: arm64: Remove list_head from hyp_page Quentin Perret
2021-06-02  9:43 ` [PATCH v2 4/7] KVM: arm64: Unify MMIO and mem host stage-2 pools Quentin Perret
2021-06-06 10:31   ` Marc Zyngier [this message]
2021-06-07  8:04     ` Quentin Perret
2021-06-02  9:43 ` [PATCH v2 5/7] KVM: arm64: Remove hyp_pool pointer from struct hyp_page Quentin Perret
2021-06-02  9:43 ` [PATCH v2 6/7] KVM: arm64: Use less bits for hyp_page order Quentin Perret
2021-06-02  9:43 ` [PATCH v2 7/7] KVM: arm64: Use less bits for hyp_page refcount Quentin Perret

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4e4647166447d8fd22b360369de4acb@kernel.org \
    --to=maz@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qperret@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).