From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF778C3F2CD for ; Mon, 23 Mar 2020 20:01:00 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 7CD7C206F9 for ; Mon, 23 Mar 2020 20:01:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bCuqD3sY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CD7C206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EDDB64A4C0; Mon, 23 Mar 2020 16:00:59 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YJLgZu9aFMV1; Mon, 23 Mar 2020 16:00:58 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CC24B4A500; Mon, 23 Mar 2020 16:00:58 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9C0F84A4BE for ; Mon, 23 Mar 2020 16:00:57 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Y+XXPPVHGqF for ; Mon, 23 Mar 2020 16:00:56 -0400 (EDT) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C8B794A4A4 for ; Mon, 23 Mar 2020 16:00:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584993656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cY+H9r1hyt0W+F/eh6c6o3kR9Aied7i4vmIsTGqyvm8=; b=bCuqD3sYav/rMPCtGTKmvRTbkWfGL+KXpOCXCfCiTeEhBXM9CZ0WIF/teLROpnsjgWdZ4U frAMcZHC/7hTIYU+qebt/GOdNAVTS8ITKwVZmNGnl9Ss2kD87mV6FkHAeanZRuK6vLvbLl mpMC6O2gDuG4tTDAc6t3sXjqnik1UuA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-r7WvugBQODiGqNEkkgksoA-1; Mon, 23 Mar 2020 16:00:55 -0400 X-MC-Unique: r7WvugBQODiGqNEkkgksoA-1 Received: by mail-wm1-f72.google.com with SMTP id f8so269306wmh.4 for ; Mon, 23 Mar 2020 13:00:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cY+H9r1hyt0W+F/eh6c6o3kR9Aied7i4vmIsTGqyvm8=; b=eY9mtz9wMrRCzMrxUk+9HhyFaFtFOmpdIxrx8iEcjx2ckN/ZA0UTIRXJ5jZfIIZe5w Qdhcql9D4TEdn/4x+93Tq0aYewFs3OCqkFfSS1a0JDf2g7Nv9dI/SnraBDzEnUQ7oMbT E6j9Hp18o6oJ0ljVgfD0L+6XUI0ntWflvWoA60uIObjgrROQPFU6OP8rrLtPbNCn6BnT 8pcQeA9VfXSjhTPAVf/8JeK7yRc13kiW81qpMwleCwgHUC229HglWKM5et6mYDHVmo6x X0c5UuFmxr0wi/gxVPhqlZ2JpLn0Z3a122hMVHgApixgrfe2u/QHaKCveWZNvCOXRclb svtw== X-Gm-Message-State: ANhLgQ1ujGmusLAq3/EyFAb3onuhqp4+UNPl394oOY/fuSK6FO3G/0mn CQB+tsBCWFlRCV+zv15/wMT4TNZ112PGZLl9sgknr4xuP2wdYMzr8g/aG6EpT+zXggmkhaRvJFE m9RVoH+23hCMYu4UMrol8fIAe X-Received: by 2002:adf:f3c5:: with SMTP id g5mr26655833wrp.230.1584993653895; Mon, 23 Mar 2020 13:00:53 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvXyqIbkkktOwq1/2ooUCj01kGPzulVzA6RfK1uS8wG/GOec0veo7shFCpnK1NWAqj8WTc9EQ== X-Received: by 2002:adf:f3c5:: with SMTP id g5mr26655802wrp.230.1584993653686; Mon, 23 Mar 2020 13:00:53 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:24d8:ed40:c82a:8a01? ([2001:b07:6468:f312:24d8:ed40:c82a:8a01]) by smtp.gmail.com with ESMTPSA id 98sm25182715wrk.52.2020.03.23.13.00.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2020 13:00:53 -0700 (PDT) Subject: Re: [PATCH v3 4/9] KVM: VMX: Configure runtime hooks using vmx_x86_ops To: Vitaly Kuznetsov , Sean Christopherson References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-5-sean.j.christopherson@intel.com> <87ftdz9ryn.fsf@vitty.brq.redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 23 Mar 2020 21:00:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <87ftdz9ryn.fsf@vitty.brq.redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , Marc Zyngier , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 23/03/20 13:27, Vitaly Kuznetsov wrote: >> - kvm_x86_ops->check_nested_events = vmx_check_nested_events; >> - kvm_x86_ops->get_nested_state = vmx_get_nested_state; >> - kvm_x86_ops->set_nested_state = vmx_set_nested_state; >> - kvm_x86_ops->get_vmcs12_pages = nested_get_vmcs12_pages; >> - kvm_x86_ops->nested_enable_evmcs = nested_enable_evmcs; >> - kvm_x86_ops->nested_get_evmcs_version = nested_get_evmcs_version; >> + ops->check_nested_events = vmx_check_nested_events; >> + ops->get_nested_state = vmx_get_nested_state; >> + ops->set_nested_state = vmx_set_nested_state; >> + ops->get_vmcs12_pages = nested_get_vmcs12_pages; >> + ops->nested_enable_evmcs = nested_enable_evmcs; >> + ops->nested_get_evmcs_version = nested_get_evmcs_version; > > A lazy guy like me would appreciate 'ops' -> 'vmx_x86_ops' rename as it > would make 'git grep vmx_x86_ops' output more complete. > I would prefer even more a kvm_x86_ops.nested struct but I would be okay with a separate patch. Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm