From: Marc Zyngier <marc.zyngier@arm.com>
To: Guoheyi <guoheyi@huawei.com>
Cc: linux-kernel@vger.kernel.org, kvmarm <kvmarm@lists.cs.columbia.edu>
Subject: Re: ARM/gic-v4: deadlock occurred
Date: Mon, 15 Jul 2019 12:13:37 +0100 [thread overview]
Message-ID: <d9015d8b-45d9-bd39-a451-1932518710e8@arm.com> (raw)
In-Reply-To: <4051528c-e282-1a04-5fa6-befd147bdbf5@huawei.com>
On 15/07/2019 11:43, Guoheyi wrote:
>
>
> On 2019/7/15 17:07, Marc Zyngier wrote:
>> On 15/07/2019 07:32, Guoheyi wrote:
>>> Hi Marc,
>>>
>>> The issue only occurs after applying the vlpi_map_rework patches, and we
>>> can see the patches only affect VM; it changes its_create_device() a
>>> little so it may affect host booting in some ways, so I took the lazy
>>> way to send it out for some insights.
>>>
>>> I am suspecting below code; if alloc_lpis == false, what will happen?
>> If !alloc_lpis, then we don't allocate the lpi_map, which is the
>> intended effect.
>>
>>> Anyway, I will investigate more on this.
>>>
>>>
>>> if (alloc_lpis) {
>>> lpi_map = its_lpi_alloc(nvecs, &lpi_base, &nr_lpis);
>>> if (lpi_map)
>>> col_map = kcalloc(nr_lpis, sizeof(*col_map),
>>> GFP_KERNEL);
>>> } else {
>>> col_map = kcalloc(nr_ites, sizeof(*col_map), GFP_KERNEL);
>>> nr_lpis = 0;
>>> lpi_base = 0;
>>> }
>>> if (its->is_v4)
>>> vlpi_map = kcalloc(nr_lpis, sizeof(*vlpi_map), GFP_KERNEL);
>>>
>>> if (!dev || !itt || !col_map || (!lpi_map && alloc_lpis) ||
>>> (!vlpi_map && its->is_v4)) {
>>> kfree(dev);
>>> kfree(itt);
>>> kfree(lpi_map);
>>> kfree(col_map);
>>> kfree(vlpi_map);
>>> return NULL;
>>> }
>> How does this relate to the patch posted in this discussion? The
>> proposed changes turn the locking from a mutex into a raw_spinlock.
>
> I'm testing the patchset in
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=irq/vlpi-map-rework,
> not only the patch posted in the mail directly. The first patch
> *"**irqchip/gic-v3-its: Make vlpi_map allocations atomic" works well in
> our internal tree, and my new testing is against the other 3 patches in
> your vlpi-map-rework branch, as I promised. I'm sorry if I didn't state
> this clearly.
Ah, I had completely forgot about this branch. As I said, it is
completely untested. I'll see if I can get some brain bandwidth in the
next couple of weeks to get back to it...
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2019-07-15 11:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9efe0260-4a84-7489-ecdd-2e9561599320@huawei.com>
2019-05-05 10:38 ` ARM/gic-v4: deadlock occurred Marc Zyngier
2019-05-05 11:07 ` Heyi Guo
2019-05-08 12:31 ` Marc Zyngier
2019-05-08 13:01 ` Heyi Guo
2019-05-09 7:48 ` Marc Zyngier
2019-05-09 11:37 ` Heyi Guo
2019-07-13 11:08 ` Guoheyi
2019-07-13 11:37 ` Marc Zyngier
2019-07-15 6:32 ` Guoheyi
2019-07-15 9:07 ` Marc Zyngier
2019-07-15 10:43 ` Guoheyi
2019-07-15 11:13 ` Marc Zyngier [this message]
2019-07-15 12:48 ` Guoheyi
2019-05-05 11:15 ` Heyi Guo
2019-05-06 9:21 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9015d8b-45d9-bd39-a451-1932518710e8@arm.com \
--to=marc.zyngier@arm.com \
--cc=guoheyi@huawei.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).