From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C3BECE58F for ; Tue, 15 Oct 2019 16:39:40 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id B2BA020872 for ; Tue, 15 Oct 2019 16:39:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PoZFMYJ+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2BA020872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3F1D44A9C5; Tue, 15 Oct 2019 12:39:39 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7MccoJ4wRvES; Tue, 15 Oct 2019 12:39:38 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3069D4A9CC; Tue, 15 Oct 2019 12:39:38 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 177EF4A9C5 for ; Tue, 15 Oct 2019 12:39:37 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FX2rzvFMoYfg for ; Tue, 15 Oct 2019 12:39:36 -0400 (EDT) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4B5214A9A1 for ; Tue, 15 Oct 2019 12:39:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571157575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=ojp02z/yPeUqI0YPPrqnloEvXX8pMYJM8GdkxYvWth0=; b=PoZFMYJ+7sxpeBeXtCRLK0g6oDkA2z3n2r34/NjLf7wdxXvZziHotiUaKgZ841qK2cavjw WJTc0ZeONaEJz/JxZjjDFMWCAOib/txMjSJCFMYErkwz86H4bzEy2FPiV9gbD0wOY2yEvO yAwZe9GWPTTBtgmmcFuCQ7GonvMsogw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-cA8ZzNyLP_GslEtJr9UGig-1; Tue, 15 Oct 2019 12:39:29 -0400 Received: by mail-wm1-f70.google.com with SMTP id z205so8904849wmb.7 for ; Tue, 15 Oct 2019 09:39:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o8Yzcui6UO5aokPFK9KbVMAamgpXNzxTPApyteJcIxI=; b=UfIMK556HGj+tfipYEhj6jUIEA3WNpjX/R0mNL6lkYnJbVQl0AtVbX5v1EdEjznLL4 NoXa3X/PyAxMHpiffGElbAQXhfKFZCHmQWcIM2KcKgxUUYcmHGsILf7WDhs9aTWBknpR oJsdK6QMbNje76wc25Qy0I3oPc6doB2fAlQQ4Gxq4p2oDlBZLLMw7ql/fNBncso67NRK kJSP7Gco1TuWhvSFKbIiES7WU2Q8Id7tnj+9+6NyhmeQDLPCaZ2qsvPEh9xRqX2+XM2+ sQf+hIG59uqicwVctBNOuZQLGmUVXQ2vaEOfNAss5Gu7FnqkiaXS/61kCYhIvllCmvFg VLSQ== X-Gm-Message-State: APjAAAVatROO/RV/ZN1zZc5JCoi+Q6wbO2G/A+z5y1ImU2i291+AkAqy 2yJY4jDCO/V0yIhUZYQOKFhHCW/7XS4poZnCQm1Vq2DRKktX3+nwicVdsJW1BNfF+87NR8iCZgc syFJWE2RjLBjY/Ji/Yab5Cskw X-Received: by 2002:adf:e747:: with SMTP id c7mr935238wrn.384.1571157568342; Tue, 15 Oct 2019 09:39:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqyejSMH01cdqlKyvOUSnepj7nqszueGVbjXDXwAp7a2kqRNxQBtic0nSge519tsU28CGqWN0A== X-Received: by 2002:adf:e747:: with SMTP id c7mr935204wrn.384.1571157568078; Tue, 15 Oct 2019 09:39:28 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:d001:591b:c73b:6c41? ([2001:b07:6468:f312:d001:591b:c73b:6c41]) by smtp.gmail.com with ESMTPSA id h7sm20388863wrs.15.2019.10.15.09.39.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Oct 2019 09:39:27 -0700 (PDT) Subject: Re: [PATCH v5 5/6] ptp: arm64: Enable ptp_kvm for arm64 To: Jianyong Wu , netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, sean.j.christopherson@intel.com, maz@kernel.org, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com References: <20191015104822.13890-1-jianyong.wu@arm.com> <20191015104822.13890-6-jianyong.wu@arm.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: Date: Tue, 15 Oct 2019 18:39:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191015104822.13890-6-jianyong.wu@arm.com> Content-Language: en-US X-MC-Unique: cA8ZzNyLP_GslEtJr9UGig-1 X-Mimecast-Spam-Score: 0 Cc: justin.he@arm.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, nd@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 15/10/19 12:48, Jianyong Wu wrote: > +int kvm_arch_ptp_get_clock_generic(struct timespec64 *ts, > + struct arm_smccc_res *hvc_res) > +{ > + u64 ns; > + ktime_t ktime_overall; > + > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID, > + hvc_res); > + if ((long)(hvc_res->a0) < 0) > + return -EOPNOTSUPP; > + > + ktime_overall = hvc_res->a0 << 32 | hvc_res->a1; > + *ts = ktime_to_timespec64(ktime_overall); > + > + return 0; > +} > + This seems wrong, who uses kvm_arch_ptp_get_clock_fn? Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm