From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF262C433FE for ; Mon, 17 Oct 2022 23:11:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4857D4B77F; Mon, 17 Oct 2022 19:11:01 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kjt6NfRTyGGK; Mon, 17 Oct 2022 19:10:59 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D6B424B743; Mon, 17 Oct 2022 19:10:59 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 50C514B712 for ; Mon, 17 Oct 2022 19:10:59 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5-+os-GDMMhD for ; Mon, 17 Oct 2022 19:10:57 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D493E4B6E2 for ; Mon, 17 Oct 2022 19:10:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666048257; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HK/sOYAOUF+Wgu2q9ChioZOCXwS8WyiwOj38FtjnWoQ=; b=MJyTzfHWlKXoD1bBQECT6V0xpR6mGtycedgOmplHeIClGSBjCNB9xircklo4LnonME7lcs 744FXdi2klleSfIp9Rn41PQ2Fd/32I7stcgMN2t9KuXcZnTttVEPu8qC0ri9A1nKLk5tzl gYxJ6vZOjl9HUWCLFQKAWbEcwxq4t1c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-1-QxuXVbsQMOqllH4t79Mxvg-1; Mon, 17 Oct 2022 19:10:54 -0400 X-MC-Unique: QxuXVbsQMOqllH4t79Mxvg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D745811E75; Mon, 17 Oct 2022 23:10:53 +0000 (UTC) Received: from [10.64.54.70] (vpn2-54-70.bne.redhat.com [10.64.54.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 522972027064; Mon, 17 Oct 2022 23:10:47 +0000 (UTC) Subject: Re: [PATCH 5/6] KVM: selftests: memslot_perf_test: Consolidate memory sizes To: "Maciej S. Szmigiero" , Sean Christopherson References: <20221014071914.227134-1-gshan@redhat.com> <20221014071914.227134-6-gshan@redhat.com> <9781c88f-06f9-4d17-8fa6-3cd82a739ccb@redhat.com> <93529fb7-f558-cc5f-d5bd-7923eb4b492c@maciej.szmigiero.name> From: Gavin Shan Message-ID: Date: Tue, 18 Oct 2022 07:10:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <93529fb7-f558-cc5f-d5bd-7923eb4b492c@maciej.szmigiero.name> Content-Language: en-US X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Cc: kvm@vger.kernel.org, maz@kernel.org, linux-kernel@vger.kernel.org, zhenyzha@redhat.com, shan.gavin@gmail.com, kvmarm@lists.linux.dev, pbonzini@redhat.com, shuah@kernel.org, kvmarm@lists.cs.columbia.edu, ajones@ventanamicro.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Gavin Shan List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMTAvMTgvMjIgNjo1NiBBTSwgTWFjaWVqIFMuIFN6bWlnaWVybyB3cm90ZToKPiBPbiAxOC4x MC4yMDIyIDAwOjUxLCBHYXZpbiBTaGFuIHdyb3RlOgo+PiBPbiAxMC8xOC8yMiA2OjA4IEFNLCBT ZWFuIENocmlzdG9waGVyc29uIHdyb3RlOgo+Pj4gT24gTW9uLCBPY3QgMTcsIDIwMjIsIE1hY2ll aiBTLiBTem1pZ2llcm8gd3JvdGU6Cj4+Pj4+ICsjZGVmaW5lIE1FTV9FWFRSQV9TSVpFwqDCoMKg wqDCoMKgwqAgMHgxMDAwMAo+Pj4+Cj4+Pj4gQWxzbywgYW4gZXhwcmVzc2lvbiBsaWtlICIoNjQg PDwgMTApIiBpcyBtb3JlIHJlYWRhYmxlIHRoYW4gYSAiMSIKPj4+PiB3aXRoIGEgdGFpbCBvZiB6 ZXJvZXMgKGl0J3MgZWFzeSB0byBhZGQgb25lIHplcm8gdG9vIG1hbnkgb3IgYmUgb25lCj4+Pj4g emVybyBzaG9ydCkuCj4+Pgo+Pj4gKzEgdG8gbm90IG9wZW4gY29kaW5nIHJhdyBudW1iZXJzLgo+ Pj4KPj4+IEkgdGhpbmsgaXQncyBoaWdoIHRpbWUgS1ZNIHNlbGZ0ZXN0cyBhZGQgI2RlZmluZXMg Zm9yIHRoZSBjb21tb24gc2l6ZXMsIGUuZy4gU0laRV80S0IsCj4+PiAxNktCLCA2NEssIDJNQiwg MUdCLCBldGMuLi4KPj4+Cj4+PiBBbHRlcm5hdGl2ZWx5IChvciBpbiBhZGRpdGlvbiksIGp1c3Qg I2RlZmluZSAxS0IsIDFNQiwgMUdCLCBhbmQgMVRCLCBhbmQgdGhlbiBkbwo+Pj4gbWF0aCBvZmYg b2YgdGhvc2UuCj4+Pgo+Pgo+PiBPay4gSSB3aWxsIGhhdmUgb25lIHNlcGFyYXRlIHBhdGNoIHRv IGRlZmluZSB0aG9zZSBzaXplcyBpbiBrdm1fdXRpbF9iYXNlLmgsCj4+IHJpZ2h0IGFmdGVyICcj ZGVmaW5lIE5TRUNfUEVSX1NFQyAxMDAwMDAwMDAwTCcuIFNlYW4sIGNvdWxkIHlvdSBsZXQgbWUg a25vdwo+PiBpZiBpdCBsb29rcyBnb29kIHRvIHlvdT8KPj4KPj4gwqDCoMKgwqAgI2RlZmluZSBL QsKgwqDCoMKgwqDCoMKgwqAgKDFVTCA8PCAxMCkKPj4gwqDCoMKgwqAgI2RlZmluZSBNQsKgwqDC oMKgwqDCoMKgwqAgKDFVTCA8PCAyMCkKPj4gwqDCoMKgwqAgI2RlZmluZSBHQsKgwqDCoMKgwqDC oMKgwqAgKDFVTCA8PCAzMCkKPj4gwqDCoMKgwqAgI2RlZmluZSBUQsKgwqDCoMKgwqDCoMKgwqAg KDFVTCA8PCA0MCkKPj4KPj4gwqDCoMKgwqAgLyogQmFzZSBwYWdlIGFuZCBodWdlIHBhZ2Ugc2l6 ZSAqLwo+PiDCoMKgwqDCoCAjZGVmaW5lIFNJWkVfNEtCwqDCoCAowqAgNCAqIEtCKQo+PiDCoMKg wqDCoCAjZGVmaW5lIFNJWkVfMTZLQsKgICggMTYgKiBLQikKPj4gwqDCoMKgwqAgI2RlZmluZSBT SVpFXzY0S0LCoCAoIDY0ICogS0IpCj4+IMKgwqDCoMKgICNkZWZpbmUgU0laRV8yTULCoMKgICjC oCAyICogTUIpCj4+IMKgwqDCoMKgICNkZWZpbmUgU0laRV8zMk1CwqAgKCAzMiAqIE1CKQo+PiDC oMKgwqDCoCAjZGVmaW5lIFNJWkVfNTEyTUIgKDUxMiAqIE1CKQo+PiDCoMKgwqDCoCAjZGVmaW5l IFNJWkVfMUdCwqDCoCAowqAgMSAqIEdCKQo+PiDCoMKgwqDCoCAjZGVmaW5lIFNJWkVfMTZHQsKg ICggMTYgKiBHQikKPiAKPiBGWUksIFFFTVUgdXNlcyBLaUIsIE1pQiwgR2lCLCBldGMuLCBzZWUg WzFdLgo+IAoKUmlnaHQuIEkgY2hlY2tlZCBRRU1VJ3MgZGVmaW5pdGlvbnMgYW5kIGl0IG1ha2Vz IHNlbnNlIHRvIHVzZQpLaUIsIE1pQiwgR2lCLCBUaUIuIEkgZG9uJ3QgdGhpbmsgd2UgbmVlZCBQ aUIgYW5kIEVpQiBiZWNhdXNlCm91ciB0ZXN0cyBkb24ndCB1c2UgdGhhdCBsYXJnZSBtZW1vcnku Cgo+IAo+IFsxXTogaHR0cHM6Ly9naXQucWVtdS5vcmcvP3A9cWVtdS5naXQ7YT1ibG9iO2Y9aW5j bHVkZS9xZW11L3VuaXRzLmg7aGI9SEVBRAo+IAoKVGhhbmtzLApHYXZpbgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdApr dm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1 L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A53084A13 for ; Mon, 17 Oct 2022 23:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666048255; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HK/sOYAOUF+Wgu2q9ChioZOCXwS8WyiwOj38FtjnWoQ=; b=fD7nlNEzIB2J9CXW8HlRODVqqF2UIswc4QF86H5aSFZL87Xz9c6RKk907He/CtHXqHQXor J/QxrdE3OTC2VOs+ulAfRUUfFrsAF/5Dr59GW8eH5Y6TI7UHeD/G5kGTnsqlWR31Prr80u hvtnNW546tjpWvm0NruQwrzKu4eIbaE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-1-QxuXVbsQMOqllH4t79Mxvg-1; Mon, 17 Oct 2022 19:10:54 -0400 X-MC-Unique: QxuXVbsQMOqllH4t79Mxvg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D745811E75; Mon, 17 Oct 2022 23:10:53 +0000 (UTC) Received: from [10.64.54.70] (vpn2-54-70.bne.redhat.com [10.64.54.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 522972027064; Mon, 17 Oct 2022 23:10:47 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH 5/6] KVM: selftests: memslot_perf_test: Consolidate memory sizes To: "Maciej S. Szmigiero" , Sean Christopherson Cc: kvmarm@lists.cs.columbia.edu, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, ajones@ventanamicro.com, pbonzini@redhat.com, maz@kernel.org, shuah@kernel.org, oliver.upton@linux.dev, peterx@redhat.com, ricarkol@google.com, zhenyzha@redhat.com, shan.gavin@gmail.com References: <20221014071914.227134-1-gshan@redhat.com> <20221014071914.227134-6-gshan@redhat.com> <9781c88f-06f9-4d17-8fa6-3cd82a739ccb@redhat.com> <93529fb7-f558-cc5f-d5bd-7923eb4b492c@maciej.szmigiero.name> From: Gavin Shan Message-ID: Date: Tue, 18 Oct 2022 07:10:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <93529fb7-f558-cc5f-d5bd-7923eb4b492c@maciej.szmigiero.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Message-ID: <20221017231044.4h56fct4QMUrvTdCQ-BgT04AgN2fL1z2pqocaLTMPH8@z> On 10/18/22 6:56 AM, Maciej S. Szmigiero wrote: > On 18.10.2022 00:51, Gavin Shan wrote: >> On 10/18/22 6:08 AM, Sean Christopherson wrote: >>> On Mon, Oct 17, 2022, Maciej S. Szmigiero wrote: >>>>> +#define MEM_EXTRA_SIZE        0x10000 >>>> >>>> Also, an expression like "(64 << 10)" is more readable than a "1" >>>> with a tail of zeroes (it's easy to add one zero too many or be one >>>> zero short). >>> >>> +1 to not open coding raw numbers. >>> >>> I think it's high time KVM selftests add #defines for the common sizes, e.g. SIZE_4KB, >>> 16KB, 64K, 2MB, 1GB, etc... >>> >>> Alternatively (or in addition), just #define 1KB, 1MB, 1GB, and 1TB, and then do >>> math off of those. >>> >> >> Ok. I will have one separate patch to define those sizes in kvm_util_base.h, >> right after '#define NSEC_PER_SEC 1000000000L'. Sean, could you let me know >> if it looks good to you? >> >>      #define KB         (1UL << 10) >>      #define MB         (1UL << 20) >>      #define GB         (1UL << 30) >>      #define TB         (1UL << 40) >> >>      /* Base page and huge page size */ >>      #define SIZE_4KB   (  4 * KB) >>      #define SIZE_16KB  ( 16 * KB) >>      #define SIZE_64KB  ( 64 * KB) >>      #define SIZE_2MB   (  2 * MB) >>      #define SIZE_32MB  ( 32 * MB) >>      #define SIZE_512MB (512 * MB) >>      #define SIZE_1GB   (  1 * GB) >>      #define SIZE_16GB  ( 16 * GB) > > FYI, QEMU uses KiB, MiB, GiB, etc., see [1]. > Right. I checked QEMU's definitions and it makes sense to use KiB, MiB, GiB, TiB. I don't think we need PiB and EiB because our tests don't use that large memory. > > [1]: https://git.qemu.org/?p=qemu.git;a=blob;f=include/qemu/units.h;hb=HEAD > Thanks, Gavin