linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Langsdorf <mlangsdo@redhat.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Robert Moore <robert.moore@intel.com>
Subject: Re: [PATCH] ACPI: SPCR: check if table->serial_port.access_width is too wide
Date: Fri, 24 Sep 2021 12:11:43 -0500	[thread overview]
Message-ID: <04187ea4-ed00-f477-f6f6-c00f9303c52d@redhat.com> (raw)
In-Reply-To: <CAJZ5v0gGena0k1ne265-+iSDRB9di24ASLuvxHHYk1R3qyz2_A@mail.gmail.com>

On 9/24/21 11:10 AM, Rafael J. Wysocki wrote:
> On Thu, Sep 16, 2021 at 9:50 PM Mark Langsdorf <mlangsdo@redhat.com> wrote:
>> If table->serial_port.access_width is more than 29, it causes
>> undefined behavior when ACPI_ACCESS_BIT_WIDTH shifts it to
>> (1 << ((size) + 2)):
>>
>> [    0.000000] UBSAN: Undefined behaviour in drivers/acpi/spcr.c:114:11
>> [    0.000000] shift exponent 102 is too large for 32-bit type 'int'
>>
>> Test that serial_port.access_width is less than 30 and set it to 6
>> if it is not.
>>
>> This consists of a Linux part and an ACPICA part (the changes in
>> actypes.h).  The ACPICA part needs to be submitted to the upstream
>> project before applying this.

Thanks, I wasn't sure of the procedure. I'll get the ACPICA part 
accepted and come back with the rest.

--Mark Langsdorf


      reply	other threads:[~2021-09-24 17:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 19:49 Mark Langsdorf
2021-09-24 16:10 ` Rafael J. Wysocki
2021-09-24 17:11   ` Mark Langsdorf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04187ea4-ed00-f477-f6f6-c00f9303c52d@redhat.com \
    --to=mlangsdo@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    --subject='Re: [PATCH] ACPI: SPCR: check if table->serial_port.access_width is too wide' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).