From: "Luck, Tony" <tony.luck@intel.com>
To: "yaoaili126@163.com" <yaoaili126@163.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>
Cc: "james.morse@arm.com" <james.morse@arm.com>,
"bp@alien8.de" <bp@alien8.de>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"yangfeng1@kingsoft.com" <yangfeng1@kingsoft.com>,
"yaoaili@kingsoft.com" <yaoaili@kingsoft.com>
Subject: RE: [PATCH] Fix incorrect return value of pre_map_gar_callback
Date: Mon, 26 Oct 2020 16:59:04 +0000 [thread overview]
Message-ID: <0976809238164c308f8e1592595899f0@intel.com> (raw)
In-Reply-To: <20201026061509.48212-1-yaoaili126@163.com>
> - if (ctx->ins_table[ins].flags & APEI_EXEC_INS_ACCESS_REGISTER)
> + if (ctx->ins_table[ins].flags & APEI_EXEC_INS_ACCESS_REGISTER &&
> + entry->register_region.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY)
I don't know (too long since I looked at APEI code) if this is the right fix, but I tried it out and it does allow einj.ko module to load.
Tested-by: Tony Luck <tony.luck@intel.com>
-Tony
next prev parent reply other threads:[~2020-10-26 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 6:15 [PATCH] Fix incorrect return value of pre_map_gar_callback yaoaili126
2020-10-26 16:59 ` Luck, Tony [this message]
2020-10-28 19:19 ` James Morse
[not found] <6b71b5b3-b423-6768-15f4-44f7aa7dc12d () arm ! com>
2020-10-29 11:30 ` yaoaili126
2020-10-30 14:03 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0976809238164c308f8e1592595899f0@intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=yangfeng1@kingsoft.com \
--cc=yaoaili126@163.com \
--cc=yaoaili@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).