From: Jiang Liu <jiang.liu@linux.intel.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Thomas Voegtle <tv@lio96.de>, Hudd <hedede.l@gmail.com>,
Prakash Punnoor <prakash@punnoor.de>,
Francois Romieu <romieu@fr.zoreil.com>,
Dave Airlie <airlied@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
Len Brown <lenb@kernel.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Lv Zheng <lv.zheng@intel.com>
Subject: [Debug 2/2] x86/PCI/ACPI: Relax ACPI resource descriptor checks to work around BIOS bugs
Date: Tue, 3 Mar 2015 12:25:41 +0800 [thread overview]
Message-ID: <1425356741-26789-3-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1425356741-26789-1-git-send-email-jiang.liu@linux.intel.com>
Some BIOSes report incorrect length for ACPI address space descriptors,
so relax the checks to avoid regressions.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
drivers/acpi/resource.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index c723668e3e27..5589a6e2a023 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -42,8 +42,10 @@ static bool acpi_dev_resource_len_valid(u64 start, u64 end, u64 len, bool io)
* CHECKME: len might be required to check versus a minimum
* length as well. 1 for io is fine, but for memory it does
* not make any sense at all.
+ * Note: some BIOSes report incorrect length for ACPI address space
+ * descriptor, so remove check of 'reslen == len' to avoid regression.
*/
- if (len && reslen && reslen == len && start <= end)
+ if (len && reslen && start <= end)
return true;
pr_debug("ACPI: invalid or unassigned resource %s [%016llx - %016llx] length [%016llx]\n",
--
1.7.10.4
next prev parent reply other threads:[~2015-03-03 4:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 4:25 [Debug 0/2] Fix regressions caused by commit 593669c2ac0f Jiang Liu
2015-03-03 4:25 ` [Debug 1/2] x86/PCI/ACPI: Ignore resources consumed by host bridge itself Jiang Liu
2015-03-03 4:25 ` Jiang Liu [this message]
2015-03-03 15:18 ` [Debug 2/2] x86/PCI/ACPI: Relax ACPI resource descriptor checks to work around BIOS bugs Bjorn Helgaas
2015-03-04 2:29 ` Jiang Liu
2015-03-04 2:58 ` Dave Airlie
2015-03-04 11:26 ` Thomas Voegtle
2015-03-04 16:05 ` Prakash Punnoor
2015-03-04 21:31 ` Hudd
2015-03-03 4:34 ` [Debug 0/2] Fix regressions caused by commit 593669c2ac0f Dave Airlie
2015-03-03 5:02 ` Jiang Liu
2015-03-03 17:19 ` Prakash Punnoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425356741-26789-3-git-send-email-jiang.liu@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=airlied@gmail.com \
--cc=bhelgaas@google.com \
--cc=hedede.l@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=marcel@holtmann.org \
--cc=prakash@punnoor.de \
--cc=rjw@rjwysocki.net \
--cc=romieu@fr.zoreil.com \
--cc=tglx@linutronix.de \
--cc=tv@lio96.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).