From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Chester Lin <clin@suse.com>
Cc: "lenb@kernel.org" <lenb@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robert.moore@intel.com" <robert.moore@intel.com>,
"erik.schmauss@intel.com" <erik.schmauss@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joey Lee <JLee@suse.com>, "mhocko@kernel.org" <mhocko@kernel.org>
Subject: Re: [RFC PATCH v2 1/3] ACPI / hotplug: Send change events for offline/online requests when eject is triggered
Date: Wed, 15 Jan 2020 11:15:08 +0100 [thread overview]
Message-ID: <1702691.vqsIMzBuNn@kreacher> (raw)
In-Reply-To: <20200103043926.31507-2-clin@suse.com>
On Friday, January 3, 2020 5:40:09 AM CET Chester Lin wrote:
> Here we change offline/online handling in device hotplug by sending change
> events to userland as notification so that userland can have control and
> determine when will be a good time to put them offline/online based on
> current workload. In this approach the real offline/online opertions are
> handed over to userland so that userland can have more time to prepare
> before any device change actually happens.
>
> All child devices under the ejection target are traversed and notified
> hierarchically based on ACPI namespace in ascending order when an eject
> event happens.
>
> Signed-off-by: Chester Lin <clin@suse.com>
So you replace the old flow with the new one and make the new one mandatory AFAICS.
Thus if anyone has relied on the old flow, they now need to switch over.
This is unfriendly and generally unwelcome, so please avoid making changes like
that.
Instead, I would consider adding a device attribute to allow user space to
opt in for getting offline notifications for specific individual devices (by
setting that attribute user space would tell the kernel that it wants to
get offline notifications for the device in question and it would take
care of offlining it as needed).
next prev parent reply other threads:[~2020-01-15 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 4:40 [RFC PATCH v2 0/3] ACPI: New eject flow to remove devices cautiously Chester Lin
2020-01-03 4:40 ` [RFC PATCH v2 1/3] ACPI / hotplug: Send change events for offline/online requests when eject is triggered Chester Lin
2020-01-15 10:15 ` Rafael J. Wysocki [this message]
2020-03-13 8:21 ` Chester Lin
2020-01-03 4:40 ` [RFC PATCH v2 2/3] ACPI / hotplug: Eject status trace and auto-remove approach Chester Lin
2020-01-03 8:33 ` gregkh
2020-01-03 4:40 ` [RFC PATCH v2 3/3] ACPI / device_sysfs: Add eject_show and add a cancel option in eject_store Chester Lin
2020-01-03 8:37 ` gregkh
2020-01-03 10:28 ` Chester Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1702691.vqsIMzBuNn@kreacher \
--to=rjw@rjwysocki.net \
--cc=JLee@suse.com \
--cc=clin@suse.com \
--cc=erik.schmauss@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).