From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E5FC433E3 for ; Fri, 29 May 2020 17:32:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A76F0207BC for ; Fri, 29 May 2020 17:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726849AbgE2RbZ (ORCPT ); Fri, 29 May 2020 13:31:25 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:41856 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726857AbgE2RXB (ORCPT ); Fri, 29 May 2020 13:23:01 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: andrzej.p) with ESMTPSA id EAFDB2A194B Subject: Re: [PATCH v4 05/11] thermal: remove get_mode() operation of drivers To: Guenter Roeck Cc: linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Emmanuel Grumbach , Heiko Stuebner , "Rafael J . Wysocki" , Vishal Kulkarni , Luca Coelho , Miquel Raynal , kernel@collabora.com, Fabio Estevam , Amit Kucheria , Chunyan Zhang , Daniel Lezcano , Allison Randal , NXP Linux Team , Darren Hart , Zhang Rui , Gayatri Kammela , Len Brown , Johannes Berg , Intel Linux Wireless , Sascha Hauer , Ido Schimmel , Baolin Wang , Jiri Pirko , Orson Zhai , Thomas Gleixner , Kalle Valo , Support Opensource , Enrico Weigelt , Peter Kaestle , Sebastian Reichel , Bartlomiej Zolnierkiewicz , Pengutronix Kernel Team , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Shawn Guo , "David S . Miller" , Andy Shevchenko References: <20200529154910.GA158174@roeck-us.net> From: Andrzej Pietrasiewicz Message-ID: <1c4a029e-bb5b-fcfd-1b4b-beea1d6fd577@collabora.com> Date: Fri, 29 May 2020 19:22:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200529154910.GA158174@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Guenter, W dniu 29.05.2020 o 17:49, Guenter Roeck pisze: > On Thu, May 28, 2020 at 09:20:45PM +0200, Andrzej Pietrasiewicz wrote: >> get_mode() is now redundant, as the state is stored in struct >> thermal_zone_device. >> >> Consequently the "mode" attribute in sysfs can always be visible, because >> it is always possible to get the mode from struct tzd. >> >> Signed-off-by: Andrzej Pietrasiewicz > > There is a slight semantic change for the two drivers which still have > a local copy of enum thermal_device_mode: Previously trying to read the > mode for those would return -EPERM since they don't have a get_mode > function. Now the global value for mode is returned, but I am not sure > if it matches the local value. Please see my replies to your comment about patch 4/11. Regards, Andrzej