From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Hanjun Guo <hanjun.guo@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Graeme Gregory <gg@slimlogic.co.uk>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Fu Wei <fu.wei@linaro.org>, Len Brown <lenb@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
rruigrok@codeaurora.org, harba@codeaurora.org,
Christopher Covington <cov@codeaurora.org>,
Timur Tabi <timur@codeaurora.org>,
G Gregory <graeme.gregory@linaro.org>,
Al Stone <al.stone@linaro.org>, Jon Masters <jcm@redhat.com>,
wei@redhat.com, Arnd
Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer
Date: Thu, 7 Jul 2016 14:40:23 +0100 [thread overview]
Message-ID: <20160707134023.GA655@red-moon> (raw)
In-Reply-To: <1890708.ZTyM2PUGdP@vostro.rjw.lan>
[+Sudeep]
On Thu, Jul 07, 2016 at 02:03:17PM +0200, Rafael J. Wysocki wrote:
[...]
> > >> So is this a documentation issue in which case Fu Wei can add that to
> > >> the file to explain its limited to ARM64. Or we could even rename the
> > >> file acpi_arm64_gtdt.c
> > >>
> > >> It seems a pity as the comment on this series were minors to block
> > >> things on a filename/location.
> > >
> > > Let me repeat what I said above:
> > >
> > > I'm mostly concerned about how (and by whom) that code is going to be
> > > maintained going forward.
> > >
> > > This is not about documentation, it is about responsibility.
> > >
> > > Honestly, I don't think I'm the right maintainer to apply the patch
> > > introducing this code and then handle bug reports regarding it and so
> > > on. That has to be done by somebody else.
> >
> > I'm working on ACPI for years and upstreamed the ARM64 ACPI core
> > support (with lots of people's help), I'm willing to maintain the ARM64
> > ACPI code under drivers/acpi/ if no objections.
>
> OK
I would ask you please to add Sudeep and myself for the ARM64 specific
ACPI code maintainership too.
> Can the ARM64-specific code go under drivers/acpi/arm64/ then, for clarity?
It can, but I do not understand why x86 should not have a separate
directory for all x86 specific stuff too then.
Anyway let's avoid these petty arguments, I agree there must be some
sort of ARM64 ACPI maintainership for the reasons you mentioned above.
> > > That's one thing.
> > >
> > > Another one is the question I asked a few messages ago: Why having the
> > > GTDT code in drivers/acpi/ is actually useful to anyone? It
> > > definitely would not be useful to me as the maintainer of
> > > drivers/acpi/, but maybe it would be useful to somebody for a specific
> > > practical reason. Or is it just "let's put this into drivers/acpi/
> > > for the lack of a better place"?
The same logic applies to eg ioapic.c but anyway, see above, if it
can help having a separate subdirectory let's do it.
> > Having GTDT code in drivers/acpi/ is useful as it is code that is used
> > by two different subsystems, clocksource and watchdog,and where people
> > look by default for utility ACPI code.
> >
> > If the mostly concerned thing (maintainer ship) is settled down, the
> > second question would be easily solved.
See above.
Thanks,
Lorenzo
next prev parent reply other threads:[~2016-07-07 13:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 18:15 [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei
2016-06-29 18:15 ` [PATCH v6 01/10] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei
2016-06-29 18:15 ` [PATCH v6 02/10] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei
2016-06-29 18:15 ` [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei
2016-06-30 2:54 ` Hanjun Guo
2016-07-07 16:12 ` Fu Wei
2016-06-29 18:15 ` [PATCH v6 04/10] acpi: Add some basic struct and functions in GTDT driver fu.wei
2016-06-29 21:24 ` Rafael J. Wysocki
2016-06-30 1:17 ` Fu Wei
2016-06-30 1:26 ` Rafael J. Wysocki
2016-06-30 1:32 ` Fu Wei
2016-06-30 4:13 ` Timur Tabi
2016-06-29 18:15 ` [PATCH v6 05/10] acpi: Add arch_timer support in GTDT table parse driver fu.wei
2016-06-29 18:15 ` [PATCH v6 06/10] acpi: Add GTDT driver to kernel build system fu.wei
2016-06-29 18:15 ` [PATCH v6 07/10] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei
2016-06-29 18:15 ` [PATCH v6 08/10] acpi: Add memory-mapped timer support in GTDT driver fu.wei
2016-06-29 18:15 ` [PATCH v6 09/10] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei
2016-06-29 18:15 ` [PATCH v6 10/10] acpi: Add SBSA Generic Watchdog support in GTDT driver fu.wei
2016-06-29 21:32 ` [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Rafael J. Wysocki
2016-06-30 1:29 ` Fu Wei
2016-06-30 1:37 ` Rafael J. Wysocki
2016-06-30 2:10 ` Hanjun Guo
2016-06-30 13:27 ` Rafael J. Wysocki
2016-06-30 13:48 ` Hanjun Guo
2016-07-01 15:23 ` Will Deacon
2016-07-01 21:04 ` Rafael J. Wysocki
2016-07-04 12:53 ` Rafael J. Wysocki
2016-07-05 14:18 ` Graeme Gregory
2016-07-06 0:00 ` Rafael J. Wysocki
2016-07-07 11:12 ` Hanjun Guo
2016-07-07 12:03 ` Rafael J. Wysocki
2016-07-07 13:40 ` Lorenzo Pieralisi [this message]
2016-07-07 13:58 ` Rafael J. Wysocki
2016-07-07 15:21 ` Fu Wei
2016-07-08 13:22 ` Lorenzo Pieralisi
2016-07-08 13:50 ` Sudeep Holla
2016-07-09 3:44 ` Hanjun Guo
2016-07-10 1:26 ` Rafael J. Wysocki
2016-07-09 3:00 ` Hanjun Guo
2016-07-01 14:00 ` Daniel Lezcano
2016-07-01 21:01 ` Rafael J. Wysocki
2016-07-04 13:43 ` Daniel Lezcano
2016-07-04 14:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707134023.GA655@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=al.stone@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=cov@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=fu.wei@linaro.org \
--cc=gg@slimlogic.co.uk \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=harba@codeaurora.org \
--cc=jcm@redhat.com \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rruigrok@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wei@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).