From: Kai Heng Feng <kai.heng.feng@canonical.com>
To: "Robert R. Howell" <RHowell@uwyo.edu>
Cc: Hans de Goede <hdegoede@redhat.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT
Date: Mon, 8 Apr 2019 11:44:11 +0800 [thread overview]
Message-ID: <EE3052A4-7566-4C92-B5FC-93918B297465@canonical.com> (raw)
Message-ID: <20190408034411._GhRhaL6YJb3nGrWel_gENMXAwJyhCkh43PgvxzPA4k@z> (raw)
In-Reply-To: <b6cd67d7-a4de-0fab-4512-25d732190d17@uwyo.edu>
at 4:58 AM, Robert R. Howell <RHowell@uwyo.edu> wrote:
> On 4/3/19 2:54 AM, Hans de Goede wrote:
>
>> Hi,
>>
>> On 03-04-19 07:43, Kai-Heng Feng wrote:
>>> i2c-designware-platdrv fails to work after the system restored from
>>> hibernation:
>>> [ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component
>>> type: 0xffffffff
>>>
>>> Commit 48402cee6889 ("ACPI / LPSS: Resume BYT/CHT I2C controllers from
>>> resume_noirq") makes acpi_lpss_{suspend_late,resume_early}() bail early
>>> on BYT/CHT as resume_from_noirq is set. This means dw_i2c_plat_resume()
>>> doesn't gets called by acpi_lpss_resume_early(), and this causes the
>>> issue.
> ...
>> The ordering problem fixed by commit 48402cee6889 can hit hibernate too,
>> so I think it would be better to do this instead to fix this problem:
>>
>> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
>> index 1e2a10a06b9d..cf768608437e 100644
> ...
>> If people affected by the problem can give my version of the fix a test,
>> then that would be great.
>>
>> Regards,
>>
>> Hans
>
> I did try applying your (Hans') patch to a 5.0.0 and a 5.1-rc3 kernel,
> instead of what I had
> been doing previously, which was reverting commit 02e45646d53b. I tested
> it on an ASUS T100TA
> and unfortunately with both kernels after resume from hibernation I still
> get errors like those
> listed below, and sound no longer works. I also tried applying the patch
> from Kai-Heng Feng
> (instead of Hans' patch or my revert) on both kernels and again in both
> cases I get these same errors.
Hmm, Hans’ works for me, as acpi_lpss_resume_noirq() calls
acpi_lpss_do_resume_early() for S4.
>
> In contrast, on the 5.0.0 kernel when I revert 02e45646d53b, the problem
> is fixed. Because
> of changes in adjacent code in 5.1-rc3, I haven't yet found a way to
> merge the new code
> and the 02e45646d53b revert without causing worse problems. But that's
> probably because
> I don't really understand the details of that code.
>
> [ 120.690428] i2c_designware 80860F41:01: timeout waiting for bus ready
> [ 120.690442] rt5640 i2c-10EC5640:00: Failed to write 13d = 3600: -110
> [ 120.712860] i2c_designware 80860F41:01: timeout waiting for bus ready
> [ 120.737389] i2c_designware 80860F41:01: timeout waiting for bus ready
> [ 120.759657] i2c_designware 80860F41:01: timeout waiting for bus ready
> [ 120.781797] i2c_designware 80860F41:01: timeout waiting for bus ready
> [ 120.804153] i2c_designware 80860F41:01: timeout waiting for bus ready
> [ 120.826467] i2c_designware 80860F41:01: timeout waiting for bus ready
> [ 121.965886] i2c_designware 80860F41:01: timeout in disabling adapter
> .....
> [ 132.782634] i2c_designware 80860F41:01: controller timed out
> [ 133.806538] i2c_designware 80860F41:01: controller timed out
> [ 134.830991] i2c_designware 80860F41:01: controller timed out
> [ 135.855183] i2c_designware 80860F41:01: controller timed out
>
> Let me know if I can do any other testing to help.
Is it possible to attach full dmesg? Thanks.
Kai-Heng
>
> Bob Howell
next prev parent reply other threads:[~2019-04-08 3:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 5:43 [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT Kai-Heng Feng
2019-04-03 8:33 ` Jarkko Nikula
2019-04-03 8:54 ` Hans de Goede
2019-04-07 20:58 ` Robert R. Howell
2019-04-07 20:58 ` Robert R. Howell
2019-04-08 3:44 ` Kai Heng Feng [this message]
2019-04-08 3:44 ` Kai Heng Feng
2019-04-11 19:50 ` Robert R. Howell
2019-04-11 19:50 ` Robert R. Howell
2019-04-08 8:16 ` Hans de Goede
2019-04-08 8:16 ` Hans de Goede
2019-04-11 19:50 ` Robert R. Howell
2019-04-11 19:50 ` Robert R. Howell
2019-04-18 11:42 ` Hans de Goede
2019-04-18 11:42 ` Hans de Goede
2019-04-19 22:44 ` Robert R. Howell
2019-04-19 22:44 ` Robert R. Howell
2019-04-23 8:07 ` Rafael J. Wysocki
2019-04-23 8:07 ` Rafael J. Wysocki
2019-04-23 20:03 ` Robert R. Howell
2019-04-23 20:03 ` Robert R. Howell
2019-04-24 7:20 ` Rafael J. Wysocki
2019-04-24 7:20 ` Rafael J. Wysocki
2019-04-25 16:38 ` Robert R. Howell
2019-04-25 16:38 ` Robert R. Howell
2019-04-30 14:39 ` Hans de Goede
2019-04-30 14:39 ` Hans de Goede
2019-05-09 4:24 ` Robert R. Howell
2019-05-09 8:50 ` Hans de Goede
2019-05-09 18:09 ` Robert R. Howell
2019-05-13 8:41 ` Hans de Goede
2019-05-16 16:34 ` Robert R. Howell
2019-05-14 10:10 ` Hans de Goede
2019-05-16 11:11 ` Rafael J. Wysocki
2019-05-16 16:35 ` Robert R. Howell
2019-05-16 22:42 ` Rafael J. Wysocki
2019-05-25 5:31 ` Robert R. Howell
2019-06-24 10:24 ` Rafael J. Wysocki
2019-06-24 10:51 ` Hans de Goede
2019-06-24 23:14 ` Rafael J. Wysocki
2019-06-26 18:43 ` Robert R. Howell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EE3052A4-7566-4C92-B5FC-93918B297465@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=RHowell@uwyo.edu \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).