From: Keith Busch <keith.busch@intel.com>
To: Brice Goglin <Brice.Goglin@inria.fr>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-mm@kvack.org, Rafael Wysocki <rafael@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCHv2 2/2] hmat: Register attributes for memory hot add
Date: Tue, 16 Apr 2019 09:01:30 -0600 [thread overview]
Message-ID: <20190416150130.GA20546@localhost.localdomain> (raw)
In-Reply-To: <9f130b73-e5ae-0529-69a1-28bd2ca29581@inria.fr>
On Tue, Apr 16, 2019 at 04:55:21PM +0200, Brice Goglin wrote:
> Hello Keith
>
> Several issues:
>
> * We always get a memory_side_cache, even if nothing was found in ACPI.
> You should at least ignore the cache if size==0?
>
> * Your code seems to only work with a single level of cache, since
> there's a single cache_attrs entry in each target structure.
>
> * I was getting a section mismatch warning and a crash on PMEM node
> hotplug until I applied the patch below.
>
> WARNING: vmlinux.o(.text+0x47d3f7): Section mismatch in reference from the function hmat_callback() to the function .init.text:hmat_register_target()
> The function hmat_callback() references
> the function __init hmat_register_target().
> This is often because hmat_callback lacks a __init
> annotation or the annotation of hmat_register_target is wrong.
>
> Thanks
>
> Brice
Oh, thanks for the notice. I'll add multi-level and no-caches into my
test, as I had it fixed to one. Will need to respin this series.
next prev parent reply other threads:[~2019-04-16 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 15:16 [PATCHv2 0/2] HMAT memroy hotplug support Keith Busch
2019-04-15 15:16 ` Keith Busch
2019-04-15 15:16 ` [PATCHv2 1/2] hmat: Register memory-side cache after parsing Keith Busch
2019-04-15 15:16 ` Keith Busch
2019-04-15 15:16 ` [PATCHv2 2/2] hmat: Register attributes for memory hot add Keith Busch
2019-04-15 15:16 ` Keith Busch
[not found] ` <9f130b73-e5ae-0529-69a1-28bd2ca29581@inria.fr>
2019-04-16 15:01 ` Keith Busch [this message]
2019-04-16 15:01 ` Keith Busch
2019-05-15 21:54 [PATCHv2 1/2] hmat: Register memory-side cache after parsing Keith Busch
2019-05-15 21:54 ` [PATCHv2 2/2] hmat: Register attributes for memory hot add Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416150130.GA20546@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=Brice.Goglin@inria.fr \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).