From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89467C43219 for ; Sat, 4 May 2019 11:07:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 583892084A for ; Sat, 4 May 2019 11:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726320AbfEDLHG (ORCPT ); Sat, 4 May 2019 07:07:06 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:7156 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725981AbfEDLHG (ORCPT ); Sat, 4 May 2019 07:07:06 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id EB4136EE082FC7102D6A; Sat, 4 May 2019 19:07:03 +0800 (CST) Received: from [127.0.0.1] (10.177.223.23) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.439.0; Sat, 4 May 2019 19:06:58 +0800 Subject: Re: [PATCH v3 0/5] arm64: SPE ACPI enablement To: Jeremy Linton , CC: , , , , , , , , , References: <20190503232407.37195-1-jeremy.linton@arm.com> From: Hanjun Guo Message-ID: <5eaa1607-4bf0-a320-e9cf-2d51eca912c6@huawei.com> Date: Sat, 4 May 2019 19:06:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20190503232407.37195-1-jeremy.linton@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.223.23] X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Message-ID: <20190504110619.OLmxSbXZwha-pr6CZ9sCcwRFK35zi0jNTexLNyFCiaI@z> Hi Jeremy, Mark, On 2019/5/4 7:24, Jeremy Linton wrote: > This patch series enables the Arm Statistical Profiling > Extension (SPE) on ACPI platforms. > > This is possible because ACPI 6.3 uses a previously > reserved field in the MADT to store the SPE interrupt > number, similarly to how the normal PMU is described. > If a consistent valid interrupt exists across all the > cores in the system, a platform device is registered. > That then triggers the SPE module, which runs as normal. > > We also add the ability to parse the PPTT for IDENTICAL > cores. We then use this to sanity check the single SPE > device we create. This creates a bit of a problem with > respect to the specification though. The specification > says that its legal for multiple tree's to exist in the > PPTT. We handle this fine, but what happens in the > case of multiple tree's is that the lack of a common > node with IDENTICAL set forces us to assume that there > are multiple non-IDENTICAL cores in the machine. Adding this patch set on top of latest mainline kernel, and tested on D06 which has the SPE feature, in boot message shows it was probed successfully: arm_spe_pmu arm,spe-v1: probed for CPUs 0-95 [max_record_sz 128, align 4, features 0x7] but when I test it with spe events such as perf record -c 1024 -e arm_spe_0/branch_filter=0/ -o spe ls it fails with: failed to mmap with 12 (Cannot allocate memory), Confirmed that patch [0] is merged and other perf events are working fine. I narrowed this issue down that mmap() failed to alloc 4M memory in perf tool but seems have no relationship with this SPE patch set, then I'm lost, could you take look please? Thanks Hanjun [0]: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=528871b456026e6127d95b1b2bd8e3a003dc1614