From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD595C04AAF for ; Tue, 21 May 2019 17:19:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B608D217D7 for ; Tue, 21 May 2019 17:19:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728055AbfEURTA (ORCPT ); Tue, 21 May 2019 13:19:00 -0400 Received: from mga04.intel.com ([192.55.52.120]:31767 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727969AbfEURTA (ORCPT ); Tue, 21 May 2019 13:19:00 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 10:18:58 -0700 X-ExtLoop1: 1 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by orsmga008.jf.intel.com with ESMTP; 21 May 2019 10:18:55 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hT8Pf-0001nL-47; Tue, 21 May 2019 20:18:55 +0300 Date: Tue, 21 May 2019 20:18:55 +0300 From: Andy Shevchenko To: Charles Keepax Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com, jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com Subject: Re: [PATCH 3/5] i2c: core: Move ACPI IRQ handling to probe time Message-ID: <20190521171855.GN9224@smile.fi.intel.com> References: <20190521150502.27305-1-ckeepax@opensource.cirrus.com> <20190521150502.27305-4-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521150502.27305-4-ckeepax@opensource.cirrus.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, May 21, 2019 at 04:05:00PM +0100, Charles Keepax wrote: > Bring the ACPI path in sync with the device tree path and handle all the > IRQ fetching at probe time. This leaves the only IRQ handling at device > registration time being that which is passed directly through the board > info as either a resource or an actual IRQ number. > -static int i2c_acpi_get_irq(struct acpi_device *adev, int *irq) > +int i2c_acpi_get_irq(struct i2c_client *client, int *irq) Instead of ping-pong style of the programming, I would rather do this in the same patch, where you introduce a helper (patch 2 I suppose, after my comments against current patch 2 in the series). Also possible to split exporting itself to a separate patch. -- With Best Regards, Andy Shevchenko