From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46E0C04AB6 for ; Fri, 31 May 2019 12:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4FE6268C2 for ; Fri, 31 May 2019 12:24:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726403AbfEaMYg (ORCPT ); Fri, 31 May 2019 08:24:36 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:55431 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbfEaMYf (ORCPT ); Fri, 31 May 2019 08:24:35 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id DF2F88031F; Fri, 31 May 2019 14:24:23 +0200 (CEST) Date: Fri, 31 May 2019 14:24:34 +0200 From: Pavel Machek To: Dan Murphy Cc: Nikolaus Voss , "Rafael J. Wysocki" , Len Brown , Robert Moore , Erik Schmauss , Jacek Anaszewski , Thierry Reding , linux-acpi@vger.kernel.org, devel@acpica.org, linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH 2/3] PWM framework: add support referencing PWMs from ACPI Message-ID: <20190531122434.GC3722@amd> References: <254cc03d5467ba7db0f5677646266768e5b24127.1559127603.git.nikolaus.voss@loewensteinmedical.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4ZLFUWh1odzi/v6L" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org --4ZLFUWh1odzi/v6L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >+struct pwm_device *acpi_pwm_get(struct fwnode_handle *fwnode) > static? > >+{ > >+ struct fwnode_reference_args args; > >+ struct pwm_chip *chip; > >+ struct pwm_device *pwm =3D ERR_PTR(-ENODEV); > >+ int ret; > >+ > >+ memset(&args, 0, sizeof(args)); >=20 > args should be zero'd out when initialized on the stack so this is > necessary. What? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --4ZLFUWh1odzi/v6L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzxHQIACgkQMOfwapXb+vKuIQCfW5dIKIOa940BDGi5OVK8pf3K ByQAnAsMR3DUm4QgoARft8zBHpwJdHyI =i6ur -----END PGP SIGNATURE----- --4ZLFUWh1odzi/v6L--