From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB52AC28CC7 for ; Mon, 3 Jun 2019 06:42:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA7F9205ED for ; Mon, 3 Jun 2019 06:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727189AbfFCGmQ (ORCPT ); Mon, 3 Jun 2019 02:42:16 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:53347 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727194AbfFCGmQ (ORCPT ); Mon, 3 Jun 2019 02:42:16 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 72C3D80295; Mon, 3 Jun 2019 08:42:03 +0200 (CEST) Date: Mon, 3 Jun 2019 08:42:12 +0200 From: Pavel Machek To: Joel Fernandes Cc: Pavel Machek , LKML , Alexey Kuznetsov , Bjorn Helgaas , Borislav Petkov , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Hideaki YOSHIFUJI , "H. Peter Anvin" , Ingo Molnar , Josh Triplett , Kees Cook , Kernel Hardening , Lai Jiangshan , Len Brown , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Linux PM , Mathieu Desnoyers , Neil Brown , netdev , Oleg Nesterov , "Paul E. McKenney" , Peter Zilstra , "Rafael J. Wysocki" , rcu , Steven Rostedt , Tejun Heo , Thomas Gleixner , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [RFC 2/6] ipv4: add lockdep condition to fix for_each_entry Message-ID: <20190603064212.GA7400@amd> References: <20190601222738.6856-1-joel@joelfernandes.org> <20190601222738.6856-3-joel@joelfernandes.org> <20190602070014.GA543@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2019-06-02 08:24:35, Joel Fernandes wrote: > On Sun, Jun 2, 2019 at 8:20 AM Joel Fernandes wr= ote: > > > > On Sun, Jun 2, 2019 at 3:00 AM Pavel Machek wrote: > > > > > > On Sat 2019-06-01 18:27:34, Joel Fernandes (Google) wrote: > > > > Signed-off-by: Joel Fernandes (Google) > > > > > > This really needs to be merged to previous patch, you can't break > > > compilation in middle of series... > > > > > > Or probably you need hlist_for_each_entry_rcu_lockdep() macro with > > > additional argument, and switch users to it. > > > > Good point. I can also just add a temporary transition macro, and then > > remove it in the last patch. That way no new macro is needed. >=20 > Actually, no. There is no compilation break so I did not follow what > you mean. The fourth argument to the hlist_for_each_entry_rcu is > optional. The only thing that happens is new lockdep warnings will > arise which later parts of the series fix by passing in that fourth > argument. Sorry, I missed that subtlety. Might be worth it enabling the lockdep warning last in the series... Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlz0wUQACgkQMOfwapXb+vJZhACeMv6qy1KMl8fpAmSRbXsFU5yP LY8Ani5H9/TBihxu13cOJbn7mJJ9RWkQ =hotv -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s--