From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B21C31E59 for ; Mon, 17 Jun 2019 13:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86555208CB for ; Mon, 17 Jun 2019 13:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726432AbfFQNJZ (ORCPT ); Mon, 17 Jun 2019 09:09:25 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46051 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbfFQNJY (ORCPT ); Mon, 17 Jun 2019 09:09:24 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id B9A7E8025E; Mon, 17 Jun 2019 15:09:11 +0200 (CEST) Date: Mon, 17 Jun 2019 15:09:21 +0200 From: Pavel Machek To: Dexuan Cui Cc: Michael Kelley , "linux-acpi@vger.kernel.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "robert.moore@intel.com" , "erik.schmauss@intel.com" , Russell King , Russ Dill , Sebastian Capella , Lorenzo Pieralisi , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , KY Srinivasan , Stephen Hemminger , Haiyang Zhang , Sasha Levin , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" , vkuznets , "marcelo.cerri@canonical.com" Subject: Re: [PATCH] ACPI: PM: Export the function acpi_sleep_state_supported() Message-ID: <20190617130921.GC21113@amd> References: <1560536224-35338-1-git-send-email-decui@microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="69pVuxX8awAiJ7fD" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org --69pVuxX8awAiJ7fD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > It seems that sleep.c isn't built when on the ARM64 architecture. Using > > acpi_sleep_state_supported() directly in hv_balloon.c will be problemat= ic > > since hv_balloon.c needs to be architecture independent when the > > Hyper-V ARM64 support is added. If that doesn't change, a per-architec= ture > > wrapper will be needed to give hv_balloon.c the correct information. T= his > > may affect whether acpi_sleep_state_supported() needs to be exported vs. > > just removing the "static". I'm not sure what the best approach is. > >=20 > > Michael >=20 > + some ARM experts who worked on arch/arm/kernel/hibernate.c. >=20 > drivers/acpi/sleep.c is only built if ACPI_SYSTEM_POWER_STATES_SUPPORT > is defined, but it looks this option is not defined on ARM. >=20 > It looks ARM does not support the ACPI S4 state, then how do we know=20 > if an ARM host supports hibernation or not? But actually... I remember ELCE talk about hibernation or ARM32. Not sure if patches are mainline, but someone was working on that. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --69pVuxX8awAiJ7fD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl0HkQEACgkQMOfwapXb+vJUqACbBRbrUMu0nfAR+ZaWSWjQrS1t 6DEAn3UmgaE6hq2ub8ECCopo61cXUVxu =V6Tb -----END PGP SIGNATURE----- --69pVuxX8awAiJ7fD--