From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <wsa@the-dreams.de>, <mika.westerberg@linux.intel.com>,
<jarkko.nikula@linux.intel.com>, <linux-i2c@vger.kernel.org>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<benjamin.tissoires@redhat.com>, <jbroadus@gmail.com>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH v5 4/7] i2c: core: Make i2c_acpi_get_irq available to the rest of the I2C core
Date: Thu, 20 Jun 2019 16:12:50 +0100 [thread overview]
Message-ID: <20190620151250.GB54126@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20190620145950.GE9224@smile.fi.intel.com>
On Thu, Jun 20, 2019 at 05:59:50PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 20, 2019 at 02:34:17PM +0100, Charles Keepax wrote:
> > In preparation for more refactoring make i2c_acpi_get_irq available
> > outside i2c-core-acpi.c.
>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> I'm not sure Rb tags are suitable for patches 4 and 5 since the changes made.
>
Apologies I figured the changes were small enough will remove for
any changes in future.
> > +struct acpi_device;
>
> Hmm... Doesn't acpi.h define that for !ACPI case?
>
Pretty sure I was getting a build error in that case.
> > #ifdef CONFIG_ACPI
> > const struct acpi_device_id *
> > i2c_acpi_match_device(const struct acpi_device_id *matches,
> > struct i2c_client *client);
> > void i2c_acpi_register_devices(struct i2c_adapter *adap);
> > +
> > +int i2c_acpi_get_irq(struct acpi_device *adev);
>
> Since you call this afterwards with struct device from which companion is
> derived, can't we directly use struct device as a parameter?
>
> Yes, in case of adev call, it might be &adev->dev I suppose?
>
A good idea I will investigate and do a respin taking in the
other comments too.
Thanks,
Charles
next prev parent reply other threads:[~2019-06-20 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 13:34 [PATCH v5 0/7] I2C IRQ Probe Improvements Charles Keepax
2019-06-20 13:34 ` [PATCH v5 1/7] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
2019-06-20 13:34 ` [PATCH v5 2/7] i2c: acpi: Use available IRQ helper functions Charles Keepax
2019-06-20 14:52 ` Andy Shevchenko
2019-06-20 15:11 ` Charles Keepax
2019-06-20 13:34 ` [PATCH v5 3/7] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
2019-06-20 14:54 ` Andy Shevchenko
2019-06-20 13:34 ` [PATCH v5 4/7] i2c: core: Make i2c_acpi_get_irq available to the rest of the I2C core Charles Keepax
2019-06-20 14:59 ` Andy Shevchenko
2019-06-20 15:12 ` Charles Keepax [this message]
2019-06-20 13:34 ` [PATCH v5 5/7] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax
2019-06-20 13:34 ` [PATCH v5 6/7] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax
2019-06-20 13:34 ` [PATCH v5 7/7] i2c: core: Tidy up handling of init_irq Charles Keepax
2019-06-20 15:00 ` [PATCH v5 0/7] I2C IRQ Probe Improvements Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620151250.GB54126@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jbroadus@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@opensource.cirrus.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).