From: Wolfram Sang <wsa@the-dreams.de>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: core: remove unused function
Date: Tue, 6 Aug 2019 22:33:14 +0200 [thread overview]
Message-ID: <20190806203314.GB911@ninjato> (raw)
In-Reply-To: <20190731105642.29664-1-anders.roxell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]
Hi Anders,
On Wed, Jul 31, 2019 at 12:56:42PM +0200, Anders Roxell wrote:
> GCC warns taht function 'i2c_acpi_find_match_adapter()' is not used.
>
> ../drivers/i2c/i2c-core-acpi.c:347:12: warning:
> ‘i2c_acpi_find_match_adapter’ defined but not used [-Wunused-function]
> static int i2c_acpi_find_match_adapter(struct device *dev, const void *data)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Rework to remove the function 'i2c_acpi_find_match_adapter()'.
>
> Fixes: 00500147cbd3 ("drivers: Introduce device lookup variants by ACPI_COMPANION device")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Can you resend with gkh and "Suzuki K Poulose <suzuki.poulose@arm.com>"
added to CC? Greg maintains a branch with device_lookup changes and
Suzuki is the author of it.
Kind regards,
Wolfram
> ---
> drivers/i2c/i2c-core-acpi.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
> index bc80aafb521f..bb6b39fe343a 100644
> --- a/drivers/i2c/i2c-core-acpi.c
> +++ b/drivers/i2c/i2c-core-acpi.c
> @@ -344,17 +344,6 @@ u32 i2c_acpi_find_bus_speed(struct device *dev)
> }
> EXPORT_SYMBOL_GPL(i2c_acpi_find_bus_speed);
>
> -static int i2c_acpi_find_match_adapter(struct device *dev, const void *data)
> -{
> - struct i2c_adapter *adapter = i2c_verify_adapter(dev);
> -
> - if (!adapter)
> - return 0;
> -
> - return ACPI_HANDLE(dev) == (acpi_handle)data;
> -}
> -
> -
> struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle)
> {
> struct device *dev = bus_find_device_by_acpi_dev(&i2c_bus_type, handle);
> --
> 2.20.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-06 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 10:56 [PATCH] i2c: core: remove unused function Anders Roxell
2019-08-06 20:33 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806203314.GB911@ninjato \
--to=wsa@the-dreams.de \
--cc=anders.roxell@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).