From: Andrew Murray <andrew.murray@arm.com>
To: Krzysztof Wilczynski <kw@linux.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement
Date: Mon, 19 Aug 2019 18:25:43 +0100 [thread overview]
Message-ID: <20190819172543.GA23903@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190819135324.29504-1-kw@linux.com>
On Mon, Aug 19, 2019 at 03:53:24PM +0200, Krzysztof Wilczynski wrote:
> Remove unnecessary parentheses enclosing the value in a return
> statement in the drivers/acpi/pci_link.c.
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
> drivers/acpi/pci_link.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index db11f7771ef1..00a6da2121be 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -661,7 +661,7 @@ int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
> ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> "Link %s is referenced\n",
> acpi_device_bid(link->device)));
> - return (link->irq.active);
> + return link->irq.active;
> }
>
> /*
> @@ -712,7 +712,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
> acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL);
>
> mutex_unlock(&acpi_link_lock);
> - return (link->irq.active);
> + return link->irq.active;
It looks like these parentheses were left over after a patch that removed some
macros:
ad550d98d3317 ("ACPI: delete tracing macros from drivers/acpi/*.c")
I can't see any you've missed so:
Reviewed-by: Andrew Murray <andrew.murray@arm.com>
> }
>
> /* --------------------------------------------------------------------------
> --
> 2.22.1
>
next prev parent reply other threads:[~2019-08-19 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 13:53 [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement Krzysztof Wilczynski
2019-08-19 17:25 ` Andrew Murray [this message]
2019-08-26 9:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819172543.GA23903@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).