Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement
@ 2019-08-19 13:53 Krzysztof Wilczynski
  2019-08-19 17:25 ` Andrew Murray
  2019-08-26  9:08 ` Rafael J. Wysocki
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Wilczynski @ 2019-08-19 13:53 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Rafael J. Wysocki, Len Brown, linux-pci, linux-acpi, linux-kernel

Remove unnecessary parentheses enclosing the value in a return
statement in the drivers/acpi/pci_link.c.

Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
---
 drivers/acpi/pci_link.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
index db11f7771ef1..00a6da2121be 100644
--- a/drivers/acpi/pci_link.c
+++ b/drivers/acpi/pci_link.c
@@ -661,7 +661,7 @@ int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
 	ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 			  "Link %s is referenced\n",
 			  acpi_device_bid(link->device)));
-	return (link->irq.active);
+	return link->irq.active;
 }
 
 /*
@@ -712,7 +712,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
 		acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL);
 
 	mutex_unlock(&acpi_link_lock);
-	return (link->irq.active);
+	return link->irq.active;
 }
 
 /* --------------------------------------------------------------------------
-- 
2.22.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement
  2019-08-19 13:53 [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement Krzysztof Wilczynski
@ 2019-08-19 17:25 ` Andrew Murray
  2019-08-26  9:08 ` Rafael J. Wysocki
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Murray @ 2019-08-19 17:25 UTC (permalink / raw)
  To: Krzysztof Wilczynski
  Cc: Bjorn Helgaas, Rafael J. Wysocki, Len Brown, linux-pci,
	linux-acpi, linux-kernel

On Mon, Aug 19, 2019 at 03:53:24PM +0200, Krzysztof Wilczynski wrote:
> Remove unnecessary parentheses enclosing the value in a return
> statement in the drivers/acpi/pci_link.c.
> 
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
>  drivers/acpi/pci_link.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index db11f7771ef1..00a6da2121be 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -661,7 +661,7 @@ int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
>  	ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>  			  "Link %s is referenced\n",
>  			  acpi_device_bid(link->device)));
> -	return (link->irq.active);
> +	return link->irq.active;
>  }
>  
>  /*
> @@ -712,7 +712,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
>  		acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL);
>  
>  	mutex_unlock(&acpi_link_lock);
> -	return (link->irq.active);
> +	return link->irq.active;

It looks like these parentheses were left over after a patch that removed some
macros:

 ad550d98d3317 ("ACPI: delete tracing macros from drivers/acpi/*.c")

I can't see any you've missed so:

Reviewed-by: Andrew Murray <andrew.murray@arm.com>


>  }
>  
>  /* --------------------------------------------------------------------------
> -- 
> 2.22.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement
  2019-08-19 13:53 [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement Krzysztof Wilczynski
  2019-08-19 17:25 ` Andrew Murray
@ 2019-08-26  9:08 ` Rafael J. Wysocki
  1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2019-08-26  9:08 UTC (permalink / raw)
  To: Krzysztof Wilczynski
  Cc: Bjorn Helgaas, Len Brown, linux-pci, linux-acpi, linux-kernel

On Monday, August 19, 2019 3:53:24 PM CEST Krzysztof Wilczynski wrote:
> Remove unnecessary parentheses enclosing the value in a return
> statement in the drivers/acpi/pci_link.c.
> 
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
>  drivers/acpi/pci_link.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index db11f7771ef1..00a6da2121be 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -661,7 +661,7 @@ int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
>  	ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>  			  "Link %s is referenced\n",
>  			  acpi_device_bid(link->device)));
> -	return (link->irq.active);
> +	return link->irq.active;
>  }
>  
>  /*
> @@ -712,7 +712,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
>  		acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL);
>  
>  	mutex_unlock(&acpi_link_lock);
> -	return (link->irq.active);
> +	return link->irq.active;
>  }
>  
>  /* --------------------------------------------------------------------------
> 

Applied, thanks!





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 13:53 [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement Krzysztof Wilczynski
2019-08-19 17:25 ` Andrew Murray
2019-08-26  9:08 ` Rafael J. Wysocki

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org linux-acpi@archiver.kernel.org
	public-inbox-index linux-acpi


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/ public-inbox