From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BB8C3A5A4 for ; Fri, 30 Aug 2019 12:22:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3B7E21874 for ; Fri, 30 Aug 2019 12:22:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbfH3MWm (ORCPT ); Fri, 30 Aug 2019 08:22:42 -0400 Received: from mga06.intel.com ([134.134.136.31]:6770 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727455AbfH3MWm (ORCPT ); Fri, 30 Aug 2019 08:22:42 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2019 05:22:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,447,1559545200"; d="scan'208";a="182639240" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007.fm.intel.com with ESMTP; 30 Aug 2019 05:22:38 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i3fvJ-0007OT-SD; Fri, 30 Aug 2019 15:22:37 +0300 Date: Fri, 30 Aug 2019 15:22:37 +0300 From: Andy Shevchenko To: Sakari Ailus Cc: Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH v3 01/10] software node: Get reference to parent swnode in get_parent op Message-ID: <20190830122237.GY2680@smile.fi.intel.com> References: <20190829101043.24963-1-sakari.ailus@linux.intel.com> <20190829101043.24963-2-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829101043.24963-2-sakari.ailus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Aug 29, 2019 at 01:10:34PM +0300, Sakari Ailus wrote: > The software_node_get_parent() returned a pointer to the parent swnode, > but did not take a reference to it, leading the caller to put a reference > that was not taken. Take that reference now. > > Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the > firmware node framework") I dunno if scripts parse the split line like above. Nevertheless, for the code prospective looks good to me. Though you probably would like to Cc it to Heikki. -- With Best Regards, Andy Shevchenko