From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F87C3A5A4 for ; Fri, 30 Aug 2019 12:26:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3554E21874 for ; Fri, 30 Aug 2019 12:26:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727751AbfH3M0Q (ORCPT ); Fri, 30 Aug 2019 08:26:16 -0400 Received: from mga17.intel.com ([192.55.52.151]:12247 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727603AbfH3M0Q (ORCPT ); Fri, 30 Aug 2019 08:26:16 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2019 05:26:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,447,1559545200"; d="scan'208";a="198026136" Received: from kuha.fi.intel.com ([10.237.72.53]) by fmsmga001.fm.intel.com with SMTP; 30 Aug 2019 05:26:13 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 30 Aug 2019 15:26:12 +0300 Date: Fri, 30 Aug 2019 15:26:12 +0300 From: Heikki Krogerus To: Sakari Ailus Cc: Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, Andy Shevchenko , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH v3 01/10] software node: Get reference to parent swnode in get_parent op Message-ID: <20190830122612.GA1636@kuha.fi.intel.com> References: <20190829101043.24963-1-sakari.ailus@linux.intel.com> <20190829101043.24963-2-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829101043.24963-2-sakari.ailus@linux.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Aug 29, 2019 at 01:10:34PM +0300, Sakari Ailus wrote: > The software_node_get_parent() returned a pointer to the parent swnode, > but did not take a reference to it, leading the caller to put a reference > that was not taken. Take that reference now. > > Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the > firmware node framework") > Signed-off-by: Sakari Ailus Reviewed-by: Heikki Krogerus > --- > drivers/base/swnode.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index e7b3aa3bd55ad..a7cb41812cfda 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -520,7 +520,10 @@ software_node_get_parent(const struct fwnode_handle *fwnode) > { > struct swnode *swnode = to_swnode(fwnode); > > - return swnode ? (swnode->parent ? &swnode->parent->fwnode : NULL) : NULL; > + if (!swnode || !swnode->parent) > + return NULL; > + > + return fwnode_handle_get(&swnode->parent->fwnode); > } > > static struct fwnode_handle * > -- > 2.20.1 thanks, -- heikki