From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v4 09/11] lib/vsprintf: OF nodes are first and foremost, struct device_nodes
Date: Mon, 2 Sep 2019 13:21:21 +0300 [thread overview]
Message-ID: <20190902102121.GD2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190902083240.20367-10-sakari.ailus@linux.intel.com>
On Mon, Sep 02, 2019 at 11:32:38AM +0300, Sakari Ailus wrote:
> Factor out static kobject_string() function that simply calls
> device_node_string(), and thus remove references to kobjects (as these are
> struct device_node).
>
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> lib/vsprintf.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index a04a2167101ef..4ad9332d54ba6 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1905,6 +1905,9 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
> struct printf_spec str_spec = spec;
> str_spec.field_width = -1;
>
> + if (fmt[0] != 'F')
> + return error_string(buf, end, "(%pO?)", spec);
> +
> if (!IS_ENABLED(CONFIG_OF))
> return error_string(buf, end, "(%pOF?)", spec);
>
> @@ -1978,17 +1981,6 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
> return widen_string(buf, buf - buf_start, end, spec);
> }
>
> -static char *kobject_string(char *buf, char *end, void *ptr,
> - struct printf_spec spec, const char *fmt)
> -{
> - switch (fmt[1]) {
> - case 'F':
> - return device_node_string(buf, end, ptr, spec, fmt + 1);
> - }
> -
> - return error_string(buf, end, "(%pO?)", spec);
> -}
> -
> /*
> * Show a '%p' thing. A kernel extension is that the '%p' is followed
> * by an extra set of alphanumeric characters that are extended format
> @@ -2167,7 +2159,7 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr,
> case 'G':
> return flags_string(buf, end, ptr, spec, fmt);
> case 'O':
> - return kobject_string(buf, end, ptr, spec, fmt);
> + return device_node_string(buf, end, ptr, spec, fmt + 1);
> case 'x':
> return pointer_string(buf, end, ptr, spec);
> }
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-02 10:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 8:32 [PATCH v4 00/11] Device property improvements, add %pfw format specifier Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 01/11] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-09-02 10:10 ` Andy Shevchenko
2019-09-02 8:32 ` [PATCH v4 02/11] software node: Make argument to to_software_node const Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 03/11] device property: Move fwnode_get_parent() up Sakari Ailus
2019-09-02 10:11 ` Andy Shevchenko
2019-09-02 8:32 ` [PATCH v4 04/11] device property: Add functions for accessing node's parents Sakari Ailus
2019-09-02 10:14 ` Andy Shevchenko
2019-09-02 12:34 ` Sakari Ailus
2019-09-02 12:46 ` Andy Shevchenko
2019-09-02 8:32 ` [PATCH v4 05/11] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 06/11] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-09-02 10:16 ` Andy Shevchenko
2019-09-02 8:32 ` [PATCH v4 07/11] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-09-02 14:39 ` Petr Mladek
2019-09-02 16:01 ` Andy Shevchenko
2019-09-03 14:04 ` Petr Mladek
2019-09-06 6:59 ` Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 08/11] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-09-02 15:18 ` Petr Mladek
2019-09-02 15:41 ` Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 09/11] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Sakari Ailus
2019-09-02 10:21 ` Andy Shevchenko [this message]
2019-09-02 8:32 ` [PATCH v4 10/11] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-09-03 13:06 ` Petr Mladek
2019-09-04 15:04 ` Sakari Ailus
2019-09-04 15:17 ` Andy Shevchenko
2019-09-04 15:39 ` Joe Perches
2019-09-04 15:54 ` Andy Shevchenko
2019-09-04 15:37 ` Joe Perches
2019-09-04 16:09 ` Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 11/11] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-09-02 12:26 ` Andy Shevchenko
2019-09-02 13:09 ` Sakari Ailus
2019-09-03 13:38 ` Petr Mladek
2019-09-04 14:03 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902102121.GD2680@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).