From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C2EEC3A59E for ; Mon, 2 Sep 2019 12:46:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BCB921883 for ; Mon, 2 Sep 2019 12:46:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730558AbfIBMqU (ORCPT ); Mon, 2 Sep 2019 08:46:20 -0400 Received: from mga12.intel.com ([192.55.52.136]:14909 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729878AbfIBMqT (ORCPT ); Mon, 2 Sep 2019 08:46:19 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 05:46:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,459,1559545200"; d="scan'208";a="382788033" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006.fm.intel.com with ESMTP; 02 Sep 2019 05:46:17 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i4liq-00021s-EE; Mon, 02 Sep 2019 15:46:16 +0300 Date: Mon, 2 Sep 2019 15:46:16 +0300 From: Andy Shevchenko To: Sakari Ailus Cc: Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Heikki Krogerus Subject: Re: [PATCH v4 04/11] device property: Add functions for accessing node's parents Message-ID: <20190902124616.GH2680@smile.fi.intel.com> References: <20190902083240.20367-1-sakari.ailus@linux.intel.com> <20190902083240.20367-5-sakari.ailus@linux.intel.com> <20190902101426.GB2680@smile.fi.intel.com> <20190902123431.GK5475@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902123431.GK5475@paasikivi.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Sep 02, 2019 at 03:34:31PM +0300, Sakari Ailus wrote: > Hi Andy, > > On Mon, Sep 02, 2019 at 01:14:26PM +0300, Andy Shevchenko wrote: > > On Mon, Sep 02, 2019 at 11:32:33AM +0300, Sakari Ailus wrote: > > > Add two convenience functions for accessing node's parents: > > > > > > fwnode_count_parents() returns the number of parent nodes a given node > > > has. fwnode_get_nth_parent() returns node's parent at a given distance > > > from the node itself. > > > > > > > Much better now, thanks! > > > > Reviewed-by: Andy Shevchenko > > > > though one question below. > > > +/** > > > + * fwnode_get_nth_parent - Return an nth parent of a node > > > + * @fwnode: The node the parent of which is requested > > > + * @depth: Distance of the parent from the node > > > + * > > > + * Returns the nth parent of a node. If @depth is 0, the functionality is > > > + * equivalent to fwnode_handle_get(). For @depth == 1, it is fwnode_get_parent() > > > + * and so on. > > > + * > > > + * The caller is responsible for calling fwnode_handle_put() for the returned > > > + * node. > > > + */ > > > +struct fwnode_handle *fwnode_get_nth_parent(struct fwnode_handle *fwnode, > > > + unsigned int depth) > > > +{ > > > + unsigned int i; > > > + > > > + fwnode_handle_get(fwnode); > > > + > > > + for (i = 0; i < depth && fwnode; i++) > > > + fwnode = fwnode_get_next_parent(fwnode); > > > + > > > > If 'fnode == NULL' and 'i < depth', shan't we return some kind of error? > > How about adding to the comment, after the first sentence of the > description: > > If there is no parent at the requested depth, NULL is returned. Works for me! -- With Best Regards, Andy Shevchenko