From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BD1C3A5A2 for ; Tue, 3 Sep 2019 13:38:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D2392343A for ; Tue, 3 Sep 2019 13:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729079AbfICNin (ORCPT ); Tue, 3 Sep 2019 09:38:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:45138 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725782AbfICNin (ORCPT ); Tue, 3 Sep 2019 09:38:43 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8EBF5B633; Tue, 3 Sep 2019 13:38:41 +0000 (UTC) Date: Tue, 3 Sep 2019 15:38:41 +0200 From: Petr Mladek To: Sakari Ailus Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Andy Shevchenko , Heikki Krogerus , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v4 11/11] lib/test_printf: Add tests for %pfw printk modifier Message-ID: <20190903133841.dhb6k2lwx2gglyjs@pathway.suse.cz> References: <20190902083240.20367-1-sakari.ailus@linux.intel.com> <20190902083240.20367-12-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902083240.20367-12-sakari.ailus@linux.intel.com> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon 2019-09-02 11:32:40, Sakari Ailus wrote: > Add a test for the %pfw printk modifier using software nodes. > > Signed-off-by: Sakari Ailus > Reviewed-by: Andy Shevchenko > --- > lib/test_printf.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 944eb50f38625..9c6d716979fb1 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -22,6 +22,8 @@ > #include > #include > > +#include > + > #include "../tools/testing/selftests/kselftest_module.h" > > #define BUF_SIZE 256 > @@ -588,6 +590,40 @@ flags(void) > kfree(cmp_buffer); > } > > +static void __init fwnode_pointer(void) > +{ > + const struct software_node softnodes[] = { > + { .name = "first", }, > + { .name = "second", .parent = &softnodes[0], }, > + { .name = "third", .parent = &softnodes[1], }, > + { NULL /* Guardian */ }, > + }; > + const char * const full_name = "/second/third"; > + const char * const full_name_second = "/second"; > + const char * const second_name = "second"; > + const char * const third_name = "third"; > + int rval; > + > + rval = software_node_register_nodes(softnodes); > + if (rval) { > + pr_warn("cannot register softnodes; rval %d\n", rval); > + return; > + } > + > + test(full_name_second, "%pfw", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 3])); "ARRAY_SIZE(softnodes) - 3" is quite cryptic. Is there any particular reason to use it instead of &softnodes[1] ? And is it expected that it does not print the "/first" parent? > + test(full_name, "%pfw", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 2])); > + test(full_name, "%pfwf", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 2])); > + test(second_name, "%pfwP", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 3])); > + test(third_name, "%pfwP", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 2])); > + > + software_node_unregister_nodes(softnodes); > +} Anyway, thanks for the tests. Best Regards, Petr