From: kbuild test robot <lkp@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: kbuild-all@01.org, Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v1 4/5] mmc: sdhci-acpi: Switch to use acpi_dev_hid_uid_match()
Date: Wed, 25 Sep 2019 01:34:12 +0800 [thread overview]
Message-ID: <201909250108.F3KSGdTa%lkp@intel.com> (raw)
In-Reply-To: <20190924120153.8382-4-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 5754 bytes --]
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on pm/linux-next]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-utils-Describe-function-parameters-in-kernel-doc/20190924-230504
base: https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~~~~~~~~~
drivers/mmc/host/sdhci-acpi.c: In function 'intel_probe_slot':
>> drivers/mmc/host/sdhci-acpi.c:381:29: error: passing argument 1 of 'acpi_dev_hid_uid_match' from incompatible pointer type [-Werror=incompatible-pointer-types]
if (acpi_dev_hid_uid_match(adev, "80860F14", "1") &&
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~~~~~~~~~~~~~~~~~~~~
drivers/mmc/host/sdhci-acpi.c:386:29: error: passing argument 1 of 'acpi_dev_hid_uid_match' from incompatible pointer type [-Werror=incompatible-pointer-types]
if (acpi_dev_hid_uid_match(adev, "80865ACA", NULL))
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~~~~~~~~~~~~~~~~~~~~
drivers/mmc/host/sdhci-acpi.c: In function 'qcom_probe_slot':
drivers/mmc/host/sdhci-acpi.c:480:29: error: passing argument 1 of 'acpi_dev_hid_uid_match' from incompatible pointer type [-Werror=incompatible-pointer-types]
if (acpi_dev_hid_uid_match(adev, "QCOM8051", NULL))
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~~~~~~~~~~~~~~~~~~~~
drivers/mmc/host/sdhci-acpi.c: In function 'qcom_free_slot':
drivers/mmc/host/sdhci-acpi.c:504:30: error: passing argument 1 of 'acpi_dev_hid_uid_match' from incompatible pointer type [-Werror=incompatible-pointer-types]
if (!acpi_dev_hid_uid_match(adev, "QCOM8051", NULL))
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~~~~~~~~~~~~~~~~~~~~
drivers/mmc/host/sdhci-acpi.c: In function 'sdhci_acpi_get_slot':
drivers/mmc/host/sdhci-acpi.c:655:30: error: passing argument 1 of 'acpi_dev_hid_uid_match' from incompatible pointer type [-Werror=incompatible-pointer-types]
if (acpi_dev_hid_uid_match(adev, u->hid, u->uid))
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/acpi_dev_hid_uid_match +381 drivers/mmc/host/sdhci-acpi.c
374
375 static int intel_probe_slot(struct platform_device *pdev, struct acpi_device *adev)
376 {
377 struct sdhci_acpi_host *c = platform_get_drvdata(pdev);
378 struct intel_host *intel_host = sdhci_acpi_priv(c);
379 struct sdhci_host *host = c->host;
380
> 381 if (acpi_dev_hid_uid_match(adev, "80860F14", "1") &&
382 sdhci_readl(host, SDHCI_CAPABILITIES) == 0x446cc8b2 &&
383 sdhci_readl(host, SDHCI_CAPABILITIES_1) == 0x00000807)
384 host->timeout_clk = 1000; /* 1000 kHz i.e. 1 MHz */
385
386 if (acpi_dev_hid_uid_match(adev, "80865ACA", NULL))
387 host->mmc_host_ops.get_cd = bxt_get_cd;
388
389 intel_dsm_init(intel_host, &pdev->dev, host->mmc);
390
391 host->mmc_host_ops.start_signal_voltage_switch =
392 intel_start_signal_voltage_switch;
393
394 return 0;
395 }
396
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54584 bytes --]
next prev parent reply other threads:[~2019-09-24 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 12:01 [PATCH v1 1/5] ACPI / utils: Describe function parameters in kernel-doc Andy Shevchenko
2019-09-24 12:01 ` [PATCH v1 2/5] ACPI / utils: Introduce acpi_dev_hid_uid_match() helper Andy Shevchenko
2019-09-24 17:24 ` kbuild test robot
2019-09-24 17:24 ` kbuild test robot
2019-09-24 12:01 ` [PATCH v1 3/5] ACPI / LPSS: Switch to use acpi_dev_hid_uid_match() Andy Shevchenko
2019-09-24 16:52 ` kbuild test robot
2019-09-24 12:01 ` [PATCH v1 4/5] mmc: sdhci-acpi: " Andy Shevchenko
2019-09-24 17:34 ` kbuild test robot [this message]
2019-09-24 12:01 ` [PATCH v1 5/5] iommu/amd: " Andy Shevchenko
2019-09-24 12:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201909250108.F3KSGdTa%lkp@intel.com \
--to=lkp@intel.com \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kbuild-all@01.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).