From: Daniel Black <daniel@linux.ibm.com>
To: Keith Busch <keith.busch@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Tao Xu <tao3.xu@intel.com>
Subject: Re: [PATCH] acpi/hmat: ACPI_HMAT_MEMORY_PD_VALID is deprecated in ACPI-6.3
Date: Wed, 2 Oct 2019 10:25:40 +1000 [thread overview]
Message-ID: <20191002102540.40492b0c@volution.ozlabs.ibm.com> (raw)
In-Reply-To: <20190903110345.4ee753c3@volution.ozlabs.ibm.com>
On Tue, 3 Sep 2019 11:03:45 +1000
Daniel Black <daniel@linux.ibm.com> wrote:
> On Mon, 2 Sep 2019 23:28:50 +0200
> "Rafael J. Wysocki" <rafael@kernel.org> wrote:
>
> > On Tue, Aug 6, 2019 at 6:24 AM Daniel Black <daniel@linux.ibm.com> wrote:
> > >
> > > ACPI-6.3 corresponds to when hmat revision was bumped from
> > > 1 to 2. In this version ACPI_HMAT_MEMORY_PD_VALID was
> > > deprecated and made reserved.
> > >
> > > As such in revision 2+ we shouldn't be testing this flag.
> > >
> > > This is as per ACPI-6.3, 5.2.27.3, Table 5-145
> > > "Memory Proximity Domain Attributes Structure"
> > > for Flags.
> > >
> > > Signed-off-by: Daniel Black <daniel@linux.ibm.com>
> >
> > Keith, any comments?
>
> FYI this was found when I was testing Tao Xu's qemu implementation of HMAT ACPI-6.3 which has no implementation of ACPI_HMAT_MEMORY_PD_VALID.
>
> Current patch implementing Memory Proximity Domain Attributes Structure:
> https://patchwork.kernel.org/patch/11125301/
On Mon, 12 Aug 2019 16:03:15 +0800
Tao Xu <tao3.xu@intel.com> wrote:
>
> Looks good to me.
>
> Reviewed-by: Tao Xu <tao3.xu@intel.com>
Ping. Any comments?
next prev parent reply other threads:[~2019-10-02 0:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 4:24 [PATCH] acpi/hmat: ACPI_HMAT_MEMORY_PD_VALID is deprecated in ACPI-6.3 Daniel Black
2019-08-12 8:03 ` Tao Xu
2019-09-02 21:28 ` Rafael J. Wysocki
2019-09-03 1:03 ` Daniel Black
2019-10-02 0:25 ` Daniel Black [this message]
2019-10-10 22:20 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002102540.40492b0c@volution.ozlabs.ibm.com \
--to=daniel@linux.ibm.com \
--cc=keith.busch@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tao3.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).