From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] device property: Fix the description of struct fwnode_operations
Date: Tue, 8 Oct 2019 17:03:06 +0300 [thread overview]
Message-ID: <20191008140306.GN32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191008132606.56434-1-heikki.krogerus@linux.intel.com>
On Tue, Oct 08, 2019 at 04:26:06PM +0300, Heikki Krogerus wrote:
> Adding description for the device_is_available member which
> was missing, and fixing the description of the member
> property_read_int_array.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> include/linux/fwnode.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 6ae05b9ce359..fc002aacae8d 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -50,11 +50,11 @@ struct fwnode_reference_args {
> * struct fwnode_operations - Operations for fwnode interface
> * @get: Get a reference to an fwnode.
> * @put: Put a reference to an fwnode.
> + * @device_is_available: Return true if the device is available.
> * @device_get_match_data: Return the device driver match data.
> * @property_present: Return true if a property is present.
> - * @property_read_integer_array: Read an array of integer properties. Return
> - * zero on success, a negative error code
> - * otherwise.
> + * @property_read_int_array: Read an array of integer properties. Return zero on
> + * success, a negative error code otherwise.
> * @property_read_string_array: Read an array of string properties. Return zero
> * on success, a negative error code otherwise.
> * @get_parent: Return the parent of an fwnode.
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-08 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 13:26 [PATCH] device property: Fix the description of struct fwnode_operations Heikki Krogerus
2019-10-08 14:03 ` Andy Shevchenko [this message]
2019-10-11 9:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008140306.GN32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).