From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Erik Schmauss <erik.schmauss@intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
linux-acpi@vger.kernel.org,
Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>,
Bob Moore <robert.moore@intel.com>
Subject: Re: [PATCH 05/12] ACPICA: make acpi_load_table() return table index
Date: Fri, 25 Oct 2019 11:19:50 +0300 [thread overview]
Message-ID: <20191025081950.GI32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191024185556.4606-6-erik.schmauss@intel.com>
On Thu, Oct 24, 2019 at 11:55:49AM -0700, Erik Schmauss wrote:
> From: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
>
> ACPICA commit d1716a829d19be23277d9157c575a03b9abb7457
>
> For unloading an ACPI table, it is necessary to provide the index of
> the table. The method intended for dynamically loading or hotplug
> addition of tables, acpi_load_table(), should provide this information
> via an optional pointer to the loaded table index.
>
> This patch fixes the table unload function of acpi_configfs.
>
Thank you!
My comments below.
First of all, can I be Cc'ed to all series to be able to test?
> Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: d06c47e3dd07f ("ACPI: configfs: Resolve objects on host-directed
> table loads")
I believe this has to be one line.
> --- a/drivers/acpi/acpi_configfs.c
> +++ b/drivers/acpi/acpi_configfs.c
> @@ -53,7 +53,7 @@ static ssize_t acpi_table_aml_write(struct config_item *cfg,
> if (!table->header)
> return -ENOMEM;
>
> - ret = acpi_load_table(table->header);
> + ret = acpi_load_table(table->header, &table->index);
> if (ret) {
> kfree(table->header);
> table->header = NULL;
As far as I understood the release notes of latest ACPICA there is also a
counterpart function being provided. That said, we need to modify ConfigFS
removing path to use the new API.
Am I correct?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-25 8:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 18:55 [PATCH 00/12] ACPICA version 20191018 Erik Schmauss
2019-10-24 18:55 ` [PATCH 01/12] ACPICA: Results from Clang changes/fixes From Clang V5.0.1. Mostly "set but never read" warnings Erik Schmauss
2019-10-24 18:55 ` [PATCH 02/12] ACPICA: Win OSL: Replace get_tick_count with get_tick_count64 Erik Schmauss
2019-10-24 18:55 ` [PATCH 03/12] ACPICA: More Clang changes - V8.0.1 Fixed all "dead assignment" warnings Erik Schmauss
2019-10-24 18:55 ` [PATCH 04/12] ACPICA: Add new external interface, acpi_unload_table Erik Schmauss
2019-10-24 18:55 ` [PATCH 05/12] ACPICA: make acpi_load_table() return table index Erik Schmauss
2019-10-25 8:19 ` Andy Shevchenko [this message]
2019-10-25 8:22 ` Rafael J. Wysocki
2019-10-24 18:55 ` [PATCH 06/12] ACPICA: utilities: add flag to only display data when dumping buffers Erik Schmauss
2019-10-24 18:55 ` [PATCH 07/12] ACPICA: Debugger: add command to dump all fields of a particular subtype Erik Schmauss
2019-10-27 20:57 ` kbuild test robot
2019-10-27 21:33 ` kbuild test robot
2019-10-24 18:55 ` [PATCH 08/12] ACPICA: debugger: surround field unit output with braces '{' Erik Schmauss
2019-10-24 18:55 ` [PATCH 09/12] ACPICA: debugger: add field unit support for acpi_db_get_next_token Erik Schmauss
2019-10-24 18:55 ` [PATCH 10/12] ACPICA: acpiexec: initialize all simple types and field units from user input Erik Schmauss
2019-10-24 18:55 ` [PATCH 11/12] ACPICA: debugger: remove leading whitespaces when converting a string to a buffer Erik Schmauss
2019-10-24 18:55 ` [PATCH 12/12] ACPICA: Update version to 20191018 Erik Schmauss
2019-10-25 9:19 ` [PATCH 00/12] ACPICA version 20191018 Rafael J. Wysocki
2019-10-25 17:08 ` Schmauss, Erik
2019-10-28 15:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025081950.GI32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=erik.schmauss@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=nikolaus.voss@loewensteinmedical.de \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).