From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ACPI / PMIC: Add byt prefix to Crystal Cove PMIC OpRegion driver
Date: Fri, 25 Oct 2019 12:33:25 +0300 [thread overview]
Message-ID: <20191025093325.GK32742@smile.fi.intel.com> (raw)
In-Reply-To: <49aa39b7-d457-1140-afdb-2a154278b29f@redhat.com>
On Fri, Oct 25, 2019 at 10:59:06AM +0200, Hans de Goede wrote:
> On 25-10-2019 09:41, Andy Shevchenko wrote:
> > On Thu, Oct 24, 2019 at 11:38:25PM +0200, Hans de Goede wrote:
> > I would go with previously established pattern, i.e. intel_pmic_bytcc.c.
> Well that would be consistent with the chtwc for the Whiskey Cove, but
> Crystal Cove related files are shortened to crc in many places already:
>
> Filenames before this patch:
> drivers/acpi/pmic/intel_pmic_crc.c
> drivers/pwm/pwm-crc.c
> drivers/mfd/intel_soc_pmic_crc.c
>
> And to me "cc" stands for the Type-C cc lines, or for Cc: from email,
> so IMHO it is best to stick with crc here.
Okay, let's do an exception here due to the fact the code and name already
exists and spreads enough thru sources.
It means you may use mine tags.
> > I'm wondering shouldn't we rename the PWM and GPIO for the sake of consistency?
> > Yes, if a driver is used on both CHT and BYT, let it provide two names.
>
> I believe it is fine to keep the blocks which are identical between
> the 2 versions as just "crystal_cove_foo", but renaming them is fine with me
> too, but that follows outside the scope of this series and should be
> done in a follow-up series IMHO.
True.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-25 9:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 21:38 [PATCH 1/4] ACPI / PMIC: Add partial support for Cherry Trail Crystal Cove PMIC Hans de Goede
2019-10-24 21:38 ` [PATCH 1/4] ACPI / PMIC: Do not register handlers for unhandled OpRegions Hans de Goede
2019-10-25 7:42 ` Andy Shevchenko
2019-10-24 21:38 ` [PATCH 2/4] ACPI / PMIC: Add byt prefix to Crystal Cove PMIC OpRegion driver Hans de Goede
2019-10-25 7:41 ` Andy Shevchenko
2019-10-25 7:48 ` Andy Shevchenko
2019-10-25 8:59 ` Hans de Goede
2019-10-25 9:33 ` Andy Shevchenko [this message]
2019-10-25 9:49 ` Rafael J. Wysocki
2019-10-24 21:38 ` [PATCH 3/4] ACPI / PMIC: Add Cherry Trail " Hans de Goede
2019-10-25 7:45 ` Andy Shevchenko
2019-10-25 9:06 ` Hans de Goede
2019-10-25 9:34 ` Andy Shevchenko
2019-10-24 21:38 ` [PATCH 4/4] mfd: intel_soc_pmic_crc: Add "cht_crystal_cove_pmic" cell to CHT cells Hans de Goede
2019-10-25 7:47 ` Andy Shevchenko
2019-11-01 9:01 ` Lee Jones
2019-11-05 23:11 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025093325.GK32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).