From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-acpi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 2/3] ACPI / LPSS: Add LNXVIDEO -> BYT I2C1 to lpss_device_links
Date: Fri, 25 Oct 2019 12:37:14 +0300 [thread overview]
Message-ID: <20191025093714.GN32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191024215723.145922-2-hdegoede@redhat.com>
On Thu, Oct 24, 2019 at 11:57:22PM +0200, Hans de Goede wrote:
> Various Asus Bay Trail devices (T100TA, T100CHI, T200TA) have an embedded
> controller connected to I2C1 and the iGPU (LNXVIDEO) _PS0/_PS3 methods
> access it, so we need to add a consumer link from LNXVIDEO to I2C1 on
> these devices to avoid suspend/resume ordering problems.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: stable@vger.kernel.org
> Fixes: 2d71ee0ce72f ("ACPI / LPSS: Add a device link from the GPU to the BYT I2C5 controller")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Add Fixes: tag
>
> Changes in v3:
> -Point Fixes tag to a more apropriate commit
> ---
> drivers/acpi/acpi_lpss.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index e7a4504f0fbf..cd8cf3333f04 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -477,6 +477,8 @@ static const struct lpss_device_links lpss_device_links[] = {
> {"808622C1", "7", "80860F14", "3", DL_FLAG_PM_RUNTIME},
> /* CHT iGPU depends on PMIC I2C controller */
> {"808622C1", "7", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME},
> + /* BYT iGPU depends on the Embedded Controller I2C controller (UID 1) */
> + {"80860F41", "1", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME},
> /* BYT CR iGPU depends on PMIC I2C controller (UID 5 on CR) */
> {"80860F41", "5", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME},
> /* BYT iGPU depends on PMIC I2C controller (UID 7 on non CR) */
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-25 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 21:57 [PATCH v3 1/3] ACPI / LPSS: Add LNXVIDEO -> BYT I2C7 to lpss_device_links Hans de Goede
2019-10-24 21:57 ` [PATCH v3 2/3] ACPI / LPSS: Add LNXVIDEO -> BYT I2C1 " Hans de Goede
2019-10-25 9:37 ` Andy Shevchenko [this message]
2019-10-24 21:57 ` [PATCH v3 3/3] ACPI / LPSS: Add dmi quirk for skipping _DEP check for some device-links Hans de Goede
2019-10-25 9:29 ` Rafael J. Wysocki
2019-10-25 9:45 ` Andy Shevchenko
2019-10-25 9:36 ` [PATCH v3 1/3] ACPI / LPSS: Add LNXVIDEO -> BYT I2C7 to lpss_device_links Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025093714.GN32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).