From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bastien Nocera <hadess@hadess.net>,
Dmitry Mastykin <mastichi@gmail.com>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] pinctrl: baytrail: Do not clear IRQ flags on direct-irq enabled pins
Date: Wed, 8 Jan 2020 19:43:34 +0200 [thread overview]
Message-ID: <20200108174334.GF32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191227230447.32458-1-hdegoede@redhat.com>
On Sat, Dec 28, 2019 at 12:04:47AM +0100, Hans de Goede wrote:
> Suspending Goodix touchscreens requires changing the interrupt pin to
> output before sending them a power-down command. Followed by wiggling
> the interrupt pin to wake the device up, after which it is put back
> in input mode.
>
> On Bay Trail devices with a Goodix touchscreen direct-irq mode is used
> in combination with listing the pin as a normal GpioIo resource.
>
> This works fine, until the goodix driver gets rmmod-ed and then insmod-ed
> again. In this case byt_gpio_disable_free() calls
> byt_gpio_clear_triggering() which clears the IRQ flags and after that the
> (direct) IRQ no longer triggers.
>
> This commit fixes this by adding a check for the BYT_DIRECT_IRQ_EN flag
> to byt_gpio_clear_triggering().
>
> Note that byt_gpio_clear_triggering() only gets called from
> byt_gpio_disable_free() for direct-irq enabled pins, as these are excluded
> from the irq_valid mask by byt_init_irq_valid_mask().
>
Pushed to my review and testing queue, thanks!
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/pinctrl/intel/pinctrl-baytrail.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index db55761c90cc..844b89f230d7 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -742,8 +742,13 @@ static void byt_gpio_clear_triggering(struct intel_pinctrl *vg, unsigned int off
>
> raw_spin_lock_irqsave(&byt_lock, flags);
> value = readl(reg);
> + /* Do not clear direct-irq enabled irqs (from gpio_disable_free) */
> + if (value & BYT_DIRECT_IRQ_EN)
> + goto out;
> +
> value &= ~(BYT_TRIG_POS | BYT_TRIG_NEG | BYT_TRIG_LVL);
> writel(value, reg);
> +out:
> raw_spin_unlock_irqrestore(&byt_lock, flags);
> }
>
> --
> 2.24.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-01-08 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 23:04 [PATCH] pinctrl: baytrail: Do not clear IRQ flags on direct-irq enabled pins Hans de Goede
2019-12-30 10:10 ` Mika Westerberg
2020-01-07 10:35 ` Linus Walleij
2020-01-07 12:38 ` Andy Shevchenko
2020-01-07 12:55 ` Linus Walleij
2020-01-07 12:57 ` Linus Walleij
2020-01-07 14:46 ` Andy Shevchenko
2020-01-08 17:43 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108174334.GF32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mastichi@gmail.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).