From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linuxarm@huawei.com, Sheng Feng <fengsheng5@huawei.com>
Subject: Re: [PATCH 1/2] i2c: designware: Add ACPI HID for Hisilicon Hip08-Lite I2C controller
Date: Sun, 2 Feb 2020 21:52:04 +0200 [thread overview]
Message-ID: <20200202195204.GV32742@smile.fi.intel.com> (raw)
In-Reply-To: <1580643255-38214-1-git-send-email-guohanjun@huawei.com>
On Sun, Feb 02, 2020 at 07:34:14PM +0800, Hanjun Guo wrote:
> Add ACPI HID HISI02A3 for Hisilicon Hip08 Lite, which has different
> clock frequency from Hip08 for I2C controller.
The series is good for me, but I think you should reverse the order of the
patches in it.
> Tested-by: Sheng Feng <fengsheng5@huawei.com>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 16dd338..3b7d58c 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -130,6 +130,7 @@ static int dw_i2c_acpi_configure(struct platform_device *pdev)
> { "APMC0D0F", 0 },
> { "HISI02A1", 0 },
> { "HISI02A2", 0 },
> + { "HISI02A3", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
> --
> 1.7.12.4
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-02-02 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 11:34 [PATCH 1/2] i2c: designware: Add ACPI HID for Hisilicon Hip08-Lite I2C controller Hanjun Guo
2020-02-02 11:34 ` [PATCH 2/2] ACPI / APD: Add clock frequency " Hanjun Guo
2020-02-02 19:52 ` Andy Shevchenko [this message]
2020-02-03 1:28 ` [PATCH 1/2] i2c: designware: Add ACPI HID " Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200202195204.GV32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=fengsheng5@huawei.com \
--cc=guohanjun@huawei.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).