From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039DBC761A6 for ; Mon, 17 Feb 2020 12:40:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF36720801 for ; Mon, 17 Feb 2020 12:40:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xB+yOUMH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728302AbgBQMkj (ORCPT ); Mon, 17 Feb 2020 07:40:39 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36668 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728228AbgBQMkj (ORCPT ); Mon, 17 Feb 2020 07:40:39 -0500 Received: by mail-wm1-f65.google.com with SMTP id p17so18298100wma.1 for ; Mon, 17 Feb 2020 04:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VM4sr45eMsFNfm3I8AuewKPZ2mzCi8kc40UVw+7O2LQ=; b=xB+yOUMH1+HqPIVwYA3f+1KohCCBUZKzi2se4L7bK+0Hs0L2ST4OcrzccxNLIKZSZL meF2am7U3/daqiwqZ2iYjulCYMVLvp6cA+U2CEevmBa4//Ar02kR0gI8SOaoXc2FPtNM 4mii9R/d783fyE/dxumDzGZA8y7IOZs1u0FLd3Z4kzBmSygQEGxTGUYOe5fqlT9fjxx2 FBivVrn9YMs6qKmDf7fYx4XhyXb2rq9Zz7yxrlKls/r0+mqTuKY6553nH6pjvXf0vhDz dxEhqGpoCEOSpWjK878ms0OPbBVieYrKP3NYoCNhXJO1KEiCzbAQp4gwPxSiLHMZGPv/ 8yrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VM4sr45eMsFNfm3I8AuewKPZ2mzCi8kc40UVw+7O2LQ=; b=hHLYXP2EIwBHAr8M1uacd3WWuWqTg0zuzs4yQ9PAHZAezOhreTeB510c15kk7C7xJG 7OmzKqZqF6JMmPoYF32hOQjjsXTElzM2stDWi1M6spyiag0mcWpuWaJ31G+mRNattbV1 Mdo3iV12CFhygP8MG97DEn85DAp+RbzFafDm8UaiTTFLQQwB0zOxBxY1pd8/3qIWRloZ cLOOdV2bzoANCUprcSMOSeQPWZdLl5tNHGDdWf+0J8BxPGhnLco0JDn3TyEPN0fcrArK u+R55Y8qLmhUac9vhWQMdshv3dNpWK8ECGYH0TRh23JHlAQ/SzgpNr43FSBgpwmZ/qlY tyYQ== X-Gm-Message-State: APjAAAXU6J+VaIPDClWARIJfpm5Agt8bJBAEOs7wfjnc87lBfhmUlcDc r7dVw5SpEsPwYRHleyLKOxdPPg== X-Google-Smtp-Source: APXvYqw7OaMmOiCFpqSYiEkkioeWfbwcKs6q33Y3t8Kyrhd1NgY0z99Vh6YZxCeeeslYOpZSiSCuUQ== X-Received: by 2002:a7b:c0d9:: with SMTP id s25mr21509184wmh.98.1581943237117; Mon, 17 Feb 2020 04:40:37 -0800 (PST) Received: from myrica ([2001:171b:2276:930:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id d16sm917782wrg.27.2020.02.17.04.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 04:40:36 -0800 (PST) Date: Mon, 17 Feb 2020 13:40:28 +0100 From: Jean-Philippe Brucker To: Rob Herring Cc: Bjorn Helgaas , Will Deacon , Lorenzo Pieralisi , Joerg Roedel , Lu Baolu , Linux Doc Mailing List , PCI , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, Linux IOMMU , Jonathan Corbet , Mark Rutland , Liviu Dudau , Sudeep Holla , Hanjun Guo , "Rafael J. Wysocki" , Len Brown , Robin Murphy , David Woodhouse , Andrew Murray , Frank Rowand Subject: Re: [PATCH 03/11] PCI: OF: Check whether the host bridge supports ATS Message-ID: <20200217124028.GC1650092@myrica> References: <20200213165049.508908-1-jean-philippe@linaro.org> <20200213165049.508908-4-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Feb 13, 2020 at 12:26:46PM -0600, Rob Herring wrote: > On Thu, Feb 13, 2020 at 10:52 AM Jean-Philippe Brucker > wrote: > > > > Copy the ats-supported flag into the pci_host_bridge structure. > > > > Signed-off-by: Jean-Philippe Brucker > > --- > > drivers/pci/controller/pci-host-common.c | 1 + > > drivers/pci/of.c | 9 +++++++++ > > include/linux/of_pci.h | 3 +++ > > 3 files changed, 13 insertions(+) > > > > diff --git a/drivers/pci/controller/pci-host-common.c b/drivers/pci/controller/pci-host-common.c > > index 250a3fc80ec6..a6ac927be291 100644 > > --- a/drivers/pci/controller/pci-host-common.c > > +++ b/drivers/pci/controller/pci-host-common.c > > @@ -92,6 +92,7 @@ int pci_host_common_probe(struct platform_device *pdev, > > return ret; > > } > > > > + of_pci_host_check_ats(bridge); > > platform_set_drvdata(pdev, bridge->bus); > > return 0; > > } > > diff --git a/drivers/pci/of.c b/drivers/pci/of.c > > index 81ceeaa6f1d5..4b8a877f1e9f 100644 > > --- a/drivers/pci/of.c > > +++ b/drivers/pci/of.c > > @@ -576,6 +576,15 @@ int pci_parse_request_of_pci_ranges(struct device *dev, > > } > > EXPORT_SYMBOL_GPL(pci_parse_request_of_pci_ranges); > > > > +void of_pci_host_check_ats(struct pci_host_bridge *bridge) > > +{ > > + struct device_node *np = bridge->bus->dev.of_node; > > + > > + if (!np) > > + return; > > + > > + bridge->ats_supported = of_property_read_bool(np, "ats-supported"); > > +} > > Not really any point in a common function if we expect this to be only > for ECAM hosts which it seems to be based on the binding. I'll move this to pci-host-common.c Thanks, Jean