Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH 1/2] PNP: constify driver name
       [not found] <1583481181-22972-1-git-send-email-clabbe@baylibre.com>
@ 2020-03-17 17:46 ` Rafael J. Wysocki
  2020-03-18  9:21   ` LABBE Corentin
  0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-03-17 17:46 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: a.zummo, alexandre.belloni, linux-kernel, linux-rtc, linux-acpi

On 3/6/2020 8:53 AM, Corentin Labbe wrote:
> struct pnp_driver has name set as char* instead of const char* like platform_driver, pci_driver, usb_driver, etc...
> Let's unify a bit by setting name as const char*.
> Furthermore, all users of this structures set name from already const
> data.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>   include/linux/pnp.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> index 3b12fd28af78..b18dca67253d 100644
> --- a/include/linux/pnp.h
> +++ b/include/linux/pnp.h
> @@ -379,7 +379,7 @@ struct pnp_id {
>   };
>   
>   struct pnp_driver {
> -	char *name;
> +	const char *name;
>   	const struct pnp_device_id *id_table;
>   	unsigned int flags;
>   	int (*probe) (struct pnp_dev *dev, const struct pnp_device_id *dev_id);

Applied as 5.7 material along with the [2/2].

BTW, please CC PNP patches to linux-acpi in the future.



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] PNP: constify driver name
  2020-03-17 17:46 ` [PATCH 1/2] PNP: constify driver name Rafael J. Wysocki
@ 2020-03-18  9:21   ` LABBE Corentin
  0 siblings, 0 replies; 2+ messages in thread
From: LABBE Corentin @ 2020-03-18  9:21 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: a.zummo, alexandre.belloni, linux-kernel, linux-rtc, linux-acpi

On Tue, Mar 17, 2020 at 06:46:24PM +0100, Rafael J. Wysocki wrote:
> On 3/6/2020 8:53 AM, Corentin Labbe wrote:
> > struct pnp_driver has name set as char* instead of const char* like platform_driver, pci_driver, usb_driver, etc...
> > Let's unify a bit by setting name as const char*.
> > Furthermore, all users of this structures set name from already const
> > data.
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> >   include/linux/pnp.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> > index 3b12fd28af78..b18dca67253d 100644
> > --- a/include/linux/pnp.h
> > +++ b/include/linux/pnp.h
> > @@ -379,7 +379,7 @@ struct pnp_id {
> >   };
> >   
> >   struct pnp_driver {
> > -	char *name;
> > +	const char *name;
> >   	const struct pnp_device_id *id_table;
> >   	unsigned int flags;
> >   	int (*probe) (struct pnp_dev *dev, const struct pnp_device_id *dev_id);
> 
> Applied as 5.7 material along with the [2/2].
> 
> BTW, please CC PNP patches to linux-acpi in the future.
> 

Perhaps it is better to update MAINTAINERS ?
I will send a patch for it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1583481181-22972-1-git-send-email-clabbe@baylibre.com>
2020-03-17 17:46 ` [PATCH 1/2] PNP: constify driver name Rafael J. Wysocki
2020-03-18  9:21   ` LABBE Corentin

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git