From: Calvin Johnson <calvin.johnson@oss.nxp.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: linux.cj@gmail.com, Jeremy Linton <jeremy.linton@arm.com>,
Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Diana Madalina Craciun <diana.craciun@nxp.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
linux-acpi@vger.kernel.org, Marcin Wojtas <mw@semihalf.com>,
Makarand Pawagi <makarand.pawagi@nxp.com>,
"Rajesh V . Bikkina" <rajesh.bikkina@nxp.com>,
Varun Sethi <V.Sethi@nxp.com>,
linux-kernel@vger.kernel.org,
Pankaj Bansal <pankaj.bansal@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [net-next PATCH v2 0/3] Introduce new APIs to support phylink and phy layers
Date: Mon, 27 Apr 2020 20:02:38 +0530 [thread overview]
Message-ID: <20200427143238.GA26436@lsv03152.swis.in-blr01.nxp.com> (raw)
In-Reply-To: <20200427135820.GH25745@shell.armlinux.org.uk>
On Mon, Apr 27, 2020 at 02:58:20PM +0100, Russell King - ARM Linux admin wrote:
> On Mon, Apr 27, 2020 at 06:54:06PM +0530, Calvin Johnson wrote:
> > Following functions are defined:
> > phylink_fwnode_phy_connect()
> > phylink_device_phy_connect()
> > fwnode_phy_find_device()
> > device_phy_find_device()
> > fwnode_get_phy_node()
> >
> > First two help in connecting phy to phylink instance.
> > Next two help in finding a phy on a mdiobus.
> > Last one helps in getting phy_node from a fwnode.
> >
> > Changes in v2:
> > move phy code from base/property.c to net/phy/phy_device.c
> > replace acpi & of code to get phy-handle with fwnode_find_reference
> > replace of_ and acpi_ code with generic fwnode to get phy-handle.
> >
> > Calvin Johnson (3):
> > device property: Introduce phy related fwnode functions
> > net: phy: alphabetically sort header includes
> > phylink: Introduce phylink_fwnode_phy_connect()
>
> Thanks for this, but there's more work that needs to be done here. I
> also think that we must have an ack from ACPI people before this can be
> accepted - you are in effect proposing a new way for representing PHYs
> in ACPI.
Thanks for your review.
Agree that we need an ack from ACPI people.
However, I don't think it is a completely new way as similar acpi approach to
get phy-handle is already in place.
Please see this:
https://elixir.bootlin.com/linux/v5.7-rc3/source/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c#L832
Please let me know, if you see more work than the ones you pointed out in your
review comments on previous patches.
Thanks
Calvin
next prev parent reply other threads:[~2020-04-27 14:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 13:24 [net-next PATCH v2 0/3] Introduce new APIs to support phylink and phy layers Calvin Johnson
2020-04-27 13:24 ` [net-next PATCH v2 1/3] device property: Introduce phy related fwnode functions Calvin Johnson
2020-04-27 13:36 ` Russell King - ARM Linux admin
2020-04-27 13:41 ` Russell King - ARM Linux admin
2020-04-27 13:24 ` [net-next PATCH v2 2/3] net: phy: alphabetically sort header includes Calvin Johnson
2020-04-27 13:24 ` [net-next PATCH v2 3/3] phylink: Introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-04-27 13:56 ` Russell King - ARM Linux admin
2020-04-27 13:58 ` [net-next PATCH v2 0/3] Introduce new APIs to support phylink and phy layers Russell King - ARM Linux admin
2020-04-27 14:32 ` Calvin Johnson [this message]
2020-04-27 14:48 ` Russell King - ARM Linux admin
2020-04-27 14:56 ` Calvin Johnson
2020-04-29 5:37 ` Calvin Johnson
2020-04-29 10:26 ` Rafael J. Wysocki
2020-05-06 12:49 ` Calvin Johnson
2020-04-30 12:05 ` Calvin Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427143238.GA26436@lsv03152.swis.in-blr01.nxp.com \
--to=calvin.johnson@oss.nxp.com \
--cc=V.Sethi@nxp.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=diana.craciun@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=florinlaurentiu.chiculita@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=makarand.pawagi@nxp.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
--cc=rajesh.bikkina@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).