From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72CC2C433DF for ; Fri, 15 May 2020 14:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40D8D20728 for ; Fri, 15 May 2020 14:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589553386; bh=Veoljy1+igqZX3k6pjqIjP7pIUUoD466ftNFEhbs7K4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HbOo1zJp3mW3FCyWrH+TGaHenAVQzOEcUm/qfcavGaKsYzHsG8o6Ro9kOrtqnRRyC gNu9Kh8Ay+sggxMLlcflZ1AZIsSn7NT9p8PE11r0QCvFGOaeYxyuto/E3ukUJ2aMVq gn8S41074xyT06IY5QzfHGt/x/92bE14pNZA6G3I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbgEOOgZ (ORCPT ); Fri, 15 May 2020 10:36:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:49012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726174AbgEOOgZ (ORCPT ); Fri, 15 May 2020 10:36:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF58D20671; Fri, 15 May 2020 14:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589553384; bh=Veoljy1+igqZX3k6pjqIjP7pIUUoD466ftNFEhbs7K4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i4M5dSEzsRnlnNkWak0gZ0CjGJmT1XV9eYjJ+dACkmPvRcFdJczuYVCaYanqpnp0N jHXXUESuWdIn7Jv8PEPRazFU/TnOSGbelYlJ9ZQlFYcagPR8ukPn7eiYF9p2dESAd2 W3gU7NVIXTkWv96+3dpFG1h0o0TtYN8Aj7/1I/eo= Date: Fri, 15 May 2020 16:36:22 +0200 From: Greg Kroah-Hartman To: Saravana Kannan Cc: "Rafael J. Wysocki" , Rob Herring , Frank Rowand , Len Brown , Android Kernel Team , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ACPI Devel Maling List , Ji Luo Subject: Re: [PATCH v1 0/4] Optimize fw_devlink parsing Message-ID: <20200515143622.GA2526356@kroah.com> References: <20200515053500.215929-1-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, May 15, 2020 at 01:52:37AM -0700, Saravana Kannan wrote: > On Thu, May 14, 2020 at 10:35 PM Saravana Kannan wrote: > > > > When fw_devlink is enabled on hardware with a large number of device > > tree nodes, the initial device addition done in > > of_platform_default_populate_init() can be very inefficient. This is > > because most devices will fail to find all their suppliers when they are > > added and will keep trying to parse their device tree nodes and link to > > any newly added devices > > > > This was an item on my TODO list that I'm finally getting around to. On > > hardware I'm testing on, this saved 1.216 _seconds_! > > Correction. It went from 1.216 _seconds_ to 61 _milliseconds_! So > about 95% reduction in time. Nice speedups! All now queued up, thanks. greg k-h