From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Tuan Phan <tuanphan@os.amperecomputing.com>, will@kernel.org
Cc: patches@amperecomputing.com, Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] ACPI/IORT: Fix PMCG node single ID mapping handling
Date: Wed, 20 May 2020 18:27:36 +0100 [thread overview]
Message-ID: <20200520172736.GA10693@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <1589994787-28637-1-git-send-email-tuanphan@os.amperecomputing.com>
On Wed, May 20, 2020 at 10:13:07AM -0700, Tuan Phan wrote:
> An IORT PMCG node can have no ID mapping if its overflow interrupt is
> wire based therefore the code that parses the PMCG node can not assume
> the node will always have a single mapping present at index 0.
>
> Fix iort_get_id_mapping_index() by checking for an overflow interrupt
> and mapping count.
>
> Fixes: 24e516049360 ("ACPI/IORT: Add support for PMCG")
>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Reviewed-by: Hanjun Guo <guoahanjun@huawei.com>
> Signed-off-by: Tuan Phan <tuanphan@os.amperecomputing.com>
> ---
> v1 -> v2:
> - Use pmcg node to detect wired base overflow interrupt.
>
> v2 -> v3:
> - Address Hanjun and Robin's comments.
>
> v3 -> v4:
> - Update the title and description as mentioned by Lorenzo.
>
> v4 -> v5:
> - Remove period in the title and commit references.
>
> drivers/acpi/arm64/iort.c | 5 +++++
Hi Will,
is there a chance we can get this patch into v5.8 ? I understand
we are very late in the cycle but I wanted to ask (it applies cleanly
to for-next/acpi).
Thanks !
Lorenzo
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index ed3d2d1..12bb70e 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -414,6 +414,7 @@ static struct acpi_iort_node *iort_node_get_id(struct acpi_iort_node *node,
> static int iort_get_id_mapping_index(struct acpi_iort_node *node)
> {
> struct acpi_iort_smmu_v3 *smmu;
> + struct acpi_iort_pmcg *pmcg;
>
> switch (node->type) {
> case ACPI_IORT_NODE_SMMU_V3:
> @@ -441,6 +442,10 @@ static int iort_get_id_mapping_index(struct acpi_iort_node *node)
>
> return smmu->id_mapping_index;
> case ACPI_IORT_NODE_PMCG:
> + pmcg = (struct acpi_iort_pmcg *)node->node_data;
> + if (pmcg->overflow_gsiv || node->mapping_count == 0)
> + return -EINVAL;
> +
> return 0;
> default:
> return -EINVAL;
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-05-20 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 17:13 [PATCH v5] ACPI/IORT: Fix PMCG node single ID mapping handling Tuan Phan
2020-05-20 17:27 ` Lorenzo Pieralisi [this message]
2020-05-20 17:43 ` Will Deacon
2020-05-20 17:54 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520172736.GA10693@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=guohanjun@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@amperecomputing.com \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=sudeep.holla@arm.com \
--cc=tuanphan@os.amperecomputing.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).