From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42949C433DF for ; Mon, 25 May 2020 11:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DBCC20723 for ; Mon, 25 May 2020 11:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389944AbgEYLGA (ORCPT ); Mon, 25 May 2020 07:06:00 -0400 Received: from mga09.intel.com ([134.134.136.24]:38845 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389897AbgEYLGA (ORCPT ); Mon, 25 May 2020 07:06:00 -0400 IronPort-SDR: N678tr+mMfA1FPgLkcyN8OCToH/ipR5ewJrnryIQ5E+wmGO0h0d59u9PMJ4Pi1WxXlnYJwJ5Dw yuJooq5Gwx2Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2020 04:05:59 -0700 IronPort-SDR: 9yVBloa/6ipEfhAtgF4ynUDXQ0ep6cGV2iadMezKZ8XtKnHMboNbY+x/dxoGhwr8YFdM/iSxP5 CHACaIpHS2zg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,433,1583222400"; d="scan'208";a="375408146" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 25 May 2020 04:05:57 -0700 Received: by lahna (sSMTP sendmail emulation); Mon, 25 May 2020 14:05:56 +0300 Date: Mon, 25 May 2020 14:05:56 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v1 5/5] gpio: pca953x: Override GpioInt() pin for Intel Galileo Gen 2 Message-ID: <20200525110556.GT247495@lahna.fi.intel.com> References: <20200520211916.25727-1-andriy.shevchenko@linux.intel.com> <20200520211916.25727-5-andriy.shevchenko@linux.intel.com> <20200525092028.GQ247495@lahna.fi.intel.com> <20200525093150.GL1634618@smile.fi.intel.com> <20200525094553.GR247495@lahna.fi.intel.com> <20200525101335.GN1634618@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200525101335.GN1634618@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, May 25, 2020 at 01:13:35PM +0300, Andy Shevchenko wrote: > Due to parsing of ACPI tables. I don't want to copy'n'paste 25% of > gpiolib-acpi.c in here. I think provided solution is cleaner and (more) > flexible in terms of maintenance. Hmm, you seem to pass a hard-coded pin number (1) to the core that then passes it back to the driver. Why you can't simple use that number here directly? You don't need to parse anything. What I'm missing? :-)