From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72B2C433E1 for ; Mon, 25 May 2020 17:58:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC9FC206DD for ; Mon, 25 May 2020 17:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389089AbgEYR6S (ORCPT ); Mon, 25 May 2020 13:58:18 -0400 Received: from mga17.intel.com ([192.55.52.151]:1962 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388621AbgEYR6S (ORCPT ); Mon, 25 May 2020 13:58:18 -0400 IronPort-SDR: 1bLnnjYspA/HiSrxC9nRy4BZBqO2w7i44M5a7SZsA94t3a+1NWxOji2sybPGzA/SUN76CRBQKn Bhf3Y2HDcjdg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2020 10:58:17 -0700 IronPort-SDR: dAW2DDab8oCauVF6/XP8YptLHsfq5RctMgjObr8XInrBa9OO/3UJmVqKGIWSS9ttndHfTM+fJS 8h8/gQttPQ0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,434,1583222400"; d="scan'208";a="441796163" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005.jf.intel.com with ESMTP; 25 May 2020 10:58:16 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jdHMh-008pwC-Cg; Mon, 25 May 2020 20:58:19 +0300 Date: Mon, 25 May 2020 20:58:19 +0300 From: Andy Shevchenko To: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Mika Westerberg , linux-acpi@vger.kernel.org Subject: Re: [PATCH v1 3/5] gpio: pca953x: Drop unneeded ACPI_PTR() Message-ID: <20200525175819.GH1634618@smile.fi.intel.com> References: <20200520211916.25727-1-andriy.shevchenko@linux.intel.com> <20200520211916.25727-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520211916.25727-3-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, May 21, 2020 at 12:19:14AM +0300, Andy Shevchenko wrote: > ACPI_PTR() becomes a no-op when !CONFIG_ACPI. This is not needed since > we always have ID table enabled. Moreover, in the mentioned case compiler > will complain about defined but not used variable. Bart, are you going to apply this one, or should I resend it as a part of v2? > Signed-off-by: Andy Shevchenko > --- > drivers/gpio/gpio-pca953x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c > index 4bb3d3524bc7..1fca8dd7824f 100644 > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -1176,7 +1176,7 @@ static struct i2c_driver pca953x_driver = { > .name = "pca953x", > .pm = &pca953x_pm_ops, > .of_match_table = pca953x_dt_ids, > - .acpi_match_table = ACPI_PTR(pca953x_acpi_ids), > + .acpi_match_table = pca953x_acpi_ids, > }, > .probe = pca953x_probe, > .remove = pca953x_remove, > -- > 2.26.2 > -- With Best Regards, Andy Shevchenko